[gcli] Make the node and nodelist types highlight matching nodes as you type

RESOLVED WONTFIX

Status

()

Firefox
Developer Tools: Graphic Commandline and Toolbar
RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: pbro, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Refactor the GCLI node and nodelist types so that matching nodes are highlighted in the page as you type.

Depends on bug 971662 which provides 2 things:
- a new gcli highlight command (already landed), which code could be reused here
- a new SelectorHighlighter (about to land in 34), which can be used to highlight nodes matching a selector

Note that:
- the type of highlighter used here should be simple (if the BoxModelHighlighter is used for this, it should probably not have all 4 regions and guides and infobar)
- there should be a threshold set somewhere to avoid highlighting thousands of nodes when typing a generic selector
(Reporter)

Comment 1

3 years ago
Created attachment 8475916 [details] [diff] [review]
bug971662-part2-gcli-highlight-node-types-while-typing.patch

Here is an old patch I had worked on while working on bug 971662. I want to keep bug 971662 simple, that's why I'm moving this patch in this new bug.

Probably needs rebasing, and should wait for the last part of bug 971662 to land before resuming the work on this.

I don't have time to work on this right now, but I can mentor if anyone's interested. I guess jwalker is probably a better mentor for this though.
(Reporter)

Updated

3 years ago
Depends on: 971662
Triage. Filter on Lobster Thermidor.
Nice idea, but it's not been worked on in 2 years, and I don't see that it's priority has increased in that time, so I don't think we need to keep it on file.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.