Get rid of ShapedButton and its subclasses

NEW
Unassigned

Status

()

4 years ago
4 years ago

People

(Reporter: lucasr, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
ShapedButton uses saveLayer() (and an equivalent technique in pre-HC) to draw our tabs button and back button. saveLayer() is a rather expensive operation and it doesn't seem to be necessary for our needs.

The right thing to do here is to simply draw the shapes with colors that respond to the view's drawable state (pressed, checked, etc) where possible. Still have to figure out how such change would interact with our lightweight themes support but it shouldn't be too complicated.
(Reporter)

Updated

4 years ago
Assignee: lucasr.at.mozilla → nobody
You need to log in before you can comment on or make changes to this bug.