Preferences are considered dirty in some cases where they're not

RESOLVED FIXED in mozilla35

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Irving, Assigned: Irving)

Tracking

Trunk
mozilla35
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

As part of fixing bug 985998, I wrote a WIP patch (https://bugzilla.mozilla.org/attachment.cgi?id=8405469) that exposes the Preferences 'dirty' flag through XPCOM and tests it from xpcshell. I found a few instances where we were marking the prefs dirty even though they weren't; the WIP includes fixes for those cases.
Dolske gets a revenge r? for teasing on #fx-team.
Assignee: nobody → irving
Status: NEW → ASSIGNED
Attachment #8480306 - Flags: review?(dolske)
Attachment #8480306 - Flags: review?(benjamin)

Updated

5 years ago
Attachment #8480306 - Flags: review?(dolske)
Attachment #8480306 - Flags: review?(benjamin)
Attachment #8480306 - Flags: review+
Do you have a Try link handy for this? :)
Keywords: checkin-needed
grumble more time wasted than saved grumble mutter mutter https://tbpl.mozilla.org/?tree=Try&rev=481df347eee1 mutter mutter grumble
Keywords: checkin-needed
sorry had to back this out for xpcshell test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=47383087&tree=Mozilla-Inbound - Could you take a look at this thanks!
Flags: needinfo?(irving)
Bah, the first patch updated the CID in the IDL, when it needed to update the UUID, and of course the Try build didn't show errors because it always clobbers so the missing build dependency updates didn't bite.

carrying forward r+ based on conversation with bsmedberg.
Attachment #8480306 - Attachment is obsolete: true
Attachment #8484223 - Flags: review+
Flags: needinfo?(irving)
https://hg.mozilla.org/mozilla-central/rev/344a4be1b051
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla35
You need to log in before you can comment on or make changes to this bug.