1056170 - Preferences are considered dirty in some cases where they're not

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[:Irving Reid (No longer working on Firefox)]

As part of fixing bug 985998, I wrote a WIP patch (https://bugzilla.mozilla.org/attachment.cgi?id=8405469) that exposes the Preferences 'dirty' flag through XPCOM and tests it from xpcshell. I found a few instances where we were marking the prefs dirty even though they weren't; the WIP includes fixes for those cases.

Comment 1

[:Irving Reid (No longer working on Firefox)]

Attachment: Expose prefs 'dirty' flag through XPCOM, test it, and fix a few cases

Dolske gets a revenge r? for teasing on #fx-team.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Do you have a Try link handy for this? :)

Comment 3

[:Irving Reid (No longer working on Firefox)]

grumble more time wasted than saved grumble mutter mutter https://tbpl.mozilla.org/?tree=Try&rev=481df347eee1 mutter mutter grumble

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4a4e0c618649

Comment 5

[Carsten Book [:Tomcat]]

sorry had to back this out for xpcshell test failures like https://tbpl.mozilla.org/php/getParsedLog.php?id=47383087&tree=Mozilla-Inbound - Could you take a look at this thanks!

Comment 6

[:Irving Reid (No longer working on Firefox)]

Attachment: Expose prefs 'dirty' flag through XPCOM, this time with UUID updated

Bah, the first patch updated the CID in the IDL, when it needed to update the UUID, and of course the Try build didn't show errors because it always clobbers so the missing build dependency updates didn't bite.

carrying forward r+ based on conversation with bsmedberg.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/344a4be1b051

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/344a4be1b051