1056194 - Modify gaia Makefile to kick off runner-service and gaia-marionette

Status: RESOLVED FIXED

(Testing Graveyard :: JSMarionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Our current setup (https://bugzilla.mozilla.org/show_bug.cgi?id=994764#c6) requires us to install the runner-service package and to call the gaia-integration cli command to run the tests. We should instead conform to how the other tests are kicked off and use the Makefile and create a make target that will do this for the user.

Comment 1

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: link to PR

R?ing yuren for the Makefile and bin/gaia-marionette change

R?ing ahal for the runner_service changes

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: link to PR

previous patch was copy-pasta'd wrong

Comment 3

[Andrew Halberstadt [:ahal]]

Comment on attachment 8494042 [details] [review]
link to PR

I'm not really sure how this works, but this is awesome!

One thing I'll mention, if manifestparser .ini style manifests are no longer being used, and if there is no longer any plan to use them.. then I'd back out bug 1039140 (though I'd encourage everyone to use manifestparser manifests :p).

Comment 4

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8494042 [details] [review]
> link to PR
> 
> I'm not really sure how this works, but this is awesome!
> 
> One thing I'll mention, if manifestparser .ini style manifests are no longer
> being used, and if there is no longer any plan to use them.. then I'd back
> out bug 1039140 (though I'd encourage everyone to use manifestparser
> manifests :p).

Yeah, tests are run using a .json manifest which is used to blacklist tests. Manifestparser and .ini style stuff doesn't seem to be used, so bug 1039140 should be backed out. I'll mark it.

Comment 5

[Malini Das [:mdas] - Away, not checking bugmail]

(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8494042 [details] [review]
> link to PR
> 
> I'm not really sure how this works, but this is awesome!

oh and all this change does is make the bin/gaia-marionette bash script kick off the runner service, so it just hangs around waiting for messages, and gets killed when that script is either killed or completes.

Comment 6

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 8494042 [details] [review]
link to PR

Reassigning r? to Ricky.

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

Ricky, in case you need some background information, this bug is needed for Bug 994764. We're enabling gaia-integration tests to use our existing automation toolchain (using the runner_service package). The tool-chain will primarily be used to help us manage devices and emulators.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8494042 [details] [review]
link to PR

Please fix nits. 

r=me. it looks good to me for both Makefile and bin/gaia-marionette.

Comment 9

[Malini Das [:mdas] - Away, not checking bugmail]

Thanks, will do!

Comment 10

[Malini Das [:mdas] - Away, not checking bugmail]

merged with whitespace fix