Closed
Bug 1056194
Opened 10 years ago
Closed 10 years ago
Modify gaia Makefile to kick off runner-service and gaia-marionette
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mdas, Assigned: mdas)
References
Details
(Whiteboard: [runner])
Attachments
(1 file, 1 obsolete file)
Our current setup (https://bugzilla.mozilla.org/show_bug.cgi?id=994764#c6) requires us to install the runner-service package and to call the gaia-integration cli command to run the tests. We should instead conform to how the other tests are kicked off and use the Makefile and create a make target that will do this for the user.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [runner]
Assignee | ||
Updated•10 years ago
|
Summary: Modify gaia Makefile to kick off runner-service → Modify gaia Makefile to kick off runner-service and gaia-marionette
Assignee | ||
Comment 1•10 years ago
|
||
R?ing yuren for the Makefile and bin/gaia-marionette change
R?ing ahal for the runner_service changes
Assignee: nobody → mdas
Attachment #8494037 -
Flags: review?(yurenju)
Attachment #8494037 -
Flags: review?(ahalberstadt)
Assignee | ||
Comment 2•10 years ago
|
||
previous patch was copy-pasta'd wrong
Attachment #8494037 -
Attachment is obsolete: true
Attachment #8494037 -
Flags: review?(yurenju)
Attachment #8494037 -
Flags: review?(ahalberstadt)
Attachment #8494042 -
Flags: review?(yurenju)
Attachment #8494042 -
Flags: review?(ahalberstadt)
Comment 3•10 years ago
|
||
Comment on attachment 8494042 [details] [review]
link to PR
I'm not really sure how this works, but this is awesome!
One thing I'll mention, if manifestparser .ini style manifests are no longer being used, and if there is no longer any plan to use them.. then I'd back out bug 1039140 (though I'd encourage everyone to use manifestparser manifests :p).
Attachment #8494042 -
Flags: review?(ahalberstadt) → review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8494042 [details] [review]
> link to PR
>
> I'm not really sure how this works, but this is awesome!
>
> One thing I'll mention, if manifestparser .ini style manifests are no longer
> being used, and if there is no longer any plan to use them.. then I'd back
> out bug 1039140 (though I'd encourage everyone to use manifestparser
> manifests :p).
Yeah, tests are run using a .json manifest which is used to blacklist tests. Manifestparser and .ini style stuff doesn't seem to be used, so bug 1039140 should be backed out. I'll mark it.
Assignee | ||
Comment 5•10 years ago
|
||
(In reply to Andrew Halberstadt [:ahal] from comment #3)
> Comment on attachment 8494042 [details] [review]
> link to PR
>
> I'm not really sure how this works, but this is awesome!
oh and all this change does is make the bin/gaia-marionette bash script kick off the runner service, so it just hangs around waiting for messages, and gets killed when that script is either killed or completes.
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8494042 [details] [review]
link to PR
Reassigning r? to Ricky.
Attachment #8494042 -
Flags: review?(yurenju) → review?(ricky060709)
Assignee | ||
Comment 7•10 years ago
|
||
Ricky, in case you need some background information, this bug is needed for Bug 994764. We're enabling gaia-integration tests to use our existing automation toolchain (using the runner_service package). The tool-chain will primarily be used to help us manage devices and emulators.
Comment 8•10 years ago
|
||
Comment on attachment 8494042 [details] [review]
link to PR
Please fix nits.
r=me. it looks good to me for both Makefile and bin/gaia-marionette.
Attachment #8494042 -
Flags: review?(ricky060709) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Thanks, will do!
Assignee | ||
Comment 10•10 years ago
|
||
merged with whitespace fix
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•