1056245 - Rocketbar search results are clipped by software home button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[:Eli Perelman]

Rocketbar search results are overlapped when the software home button (SHB) is enabled.

STR:

1. Enable Software home button in Settings > Developer > Window Management
2. Return to home screen (press the SHB)
3. Tap the Rocketbar search input
4. Type "e" (just a short search with lots of results)
5. Hide the keyboard by long-pressing the spacebar
6. Scroll to bottom

Expected result:
  Search results should have a sufficient gap above the SHB

Actual result:
  Observe how last row of results is clipped by the SHB

Comment 1

[:Eli Perelman]

Attachment: rocketbar-search-results.png

Comment 2

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23104

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8476115 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23104

That turned out to be an easy fix, thanks! I guess the implementation just changed in the past adjusting the height. I wish we could use something like calc() with css vars here.

Comment 4

[:Eli Perelman]

Agreed, I'm not really caring much for the use of the 5rem value all over Gaia's CSS.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/7080cc6e1813a7ed8fa906ed250839dc48063e72

Comment 6

[Lancy(Leave from Mozilla)]

Attachment: Verify_Video_Flame.MP4

This issue has been verified successfully on Flame 2.1.
See attachment: Verify_Video_Flame.MP4
Reproducing rate: 0/10

Flame v2.1 version:
Gaia-Rev        5372b675e018b6aac97d95ff5db8d4bd16addb9b
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/f34377ae402b
Build-ID        20141127001201
Version         34.0