Update invocation of setTextureCacheLimits to its new name

RESOLVED FIXED in mozilla34

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks 1 bug)

Trunk
mozilla34
x86_64
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Build warning:
{
 2:04.12 Warning: -Wdeprecated-declarations in $SRCDIR/gfx/thebes/gfxPlatform.cpp: 'setTextureCacheLimits' is deprecated
 2:04.13 $SRCDIR/gfx/thebes/gfxPlatform.cpp:870:32: warning: 'setTextureCacheLimits' is deprecated [-Wdeprecated-declarations]
 2:04.13     mSkiaGlue->GetGrContext()->setTextureCacheLimits(cacheItemLimit, cacheSizeLimit);
 2:04.13                                ^
 2:04.13 ../../dist/include/skia/GrContext.h:159:10: note: 'setTextureCacheLimits' has been explicitly marked deprecated here
 2:04.13     void setTextureCacheLimits(int maxTextures, size_t maxTextureBytes) {
 2:04.13          ^
}

It's only deprecated because it's been renamed:
> 157     void setResourceCacheLimits(int maxResources, size_t maxResourceBytes);
> 158     SK_ATTR_DEPRECATED("This function has been renamed to setResourceCacheLimits().")
> 159     void setTextureCacheLimits(int maxTextures, size_t maxTextureBytes) {
> 160         this->setResourceCacheLimits(maxTextures, maxTextureBytes);
> 161     }
http://mxr.mozilla.org/mozilla-central/source/gfx/skia/trunk/include/gpu/GrContext.h?rev=883cd6be06d2#159

The rename happened in a skia update that we took last month, in bug 1017113.

We should update the invocation in gfxPlatform.cpp to use the renamed version of this function.
Posted patch fixSplinter Review
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #8476121 - Flags: review?(snorp)
(Adding dependency on bug 939276, which added this line of code [before the skia update that renamed the function].)
Depends on: 939276
(In reply to Daniel Holbert [:dholbert] from comment #0)
> The rename happened in a skia update that we took last month, in bug 1017113.

er, s/last month/last week/.  (I was initially going off of the July datestamp on the commit, but it lies.)
Attachment #8476121 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/b6e328e2e2b5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.