1056268 - [Contacts] when importing contacts search function is missing functionality

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[[:RJ]]

Attachment: 2014-08-20-11-18-37.png

Description:
 In 2.1 when importing contacts search function is missing functionality, including showing multipul results and highlighting letters typed

Repro Steps:
1) Update a Flame to 20140819040202
2) Go to the contact app < go to settings > go to Import
3) Select import from Outlook > log in to valid account 
4) Type one letter into the search bar 


Actual:
one result with nothing showing why it was a result 


Expected:
Any matching result with the matching veriable higlighted 

Environmental Variables:
Device: Flame Master
Build ID: 20140819040202
Gaia: b33b4d9558e0b9eabbfda7be23435e2b38fd40bf
Gecko: 111a1da2a95d
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Keywords: Import, outlook, out look, hotmail, hot mail, Contacts 

Repro frequency:100%, 
Link to failed test case:
See attached: screenshot

Comment 1

[[:RJ]]

this issue occures only on the flame 2.1 and buri 2.1

when importing contacts search function is missing functionality, including showing multipul results and highlighting letters typed


"Flame 2.1

Environmental Variables:
Device: Flame Master (319mb)
BuildID: 20140820040203193
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"

"Buri 2.1

Environmental Variables:
Device: Buri Master
Build ID: 20140820073027
Gaia: 33d4b999f464fbad1c23d488da4689c5de9967ec
Gecko: cbbc380f1e1c
Version: 34.0a1 (Master)
Firmware Version: v1.2device.cfg
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0"

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Brogan, please clean up this issue to make it more clear.

Comment 3

[Brogan Zumwalt [Inactive]]

When trying to import contacts from Outlook, the search functionality appears broken.

In other search scenarios, if user types name in search field the highlighted letters appear in search results to indicate how they are related to the current search query. This functionality does not appear to be present when user searches through Outlook contacts to import as no highlighting of letters occurs during search.

The Outlook search results only display one result no matter what the query is typed. For instance if user has three contacts in Outlook with the names "Fake Name", "Name Lastname", and "Nagorb Uz" a search query of "Na" only displays "Fake Name" as a result. The expected result would be that all three contacts appear.

Comment 4

[KTucker [:KTucker][Inactive 3/4/2016]]

We are missing branch checks here.

Comment 5

[Brogan Zumwalt [Inactive]]

Issue DOES occur on 2.1 Flame (512mb) and 2.1 OpenC

Environmental Variables:
Device: Flame Master (512mb)
BuildID: 20140820040203193
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Open_C Master
Build ID: 20140820040203
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Actual Results: 
Search results do not show highlighting or full expected results for query.


Issue does NOT occur on 2.0 Flame (319mb), 2.0 OpenC, 1.4 Flame (319mb), and 1.4 OpenC

Environmental Variables:
Device: Flame 2.0 (319mb)
BuildID: 20140820000201
Gaia: 88db39a0826086024631049d83ae6aa397f0918d
Gecko: 2092ac87eceb
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C 2.0
BuildID: 20140820000201
Gaia: 88db39a0826086024631049d83ae6aa397f0918d
Gecko: 2092ac87eceb
Version: 32.0 (2.0) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 1.4
Build ID: 20140820003001
Gaia: 4f92950e6d96326785a249e8acb704da3647616b
Gecko: e1de5a959089
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Environmental Variables:
Device: Open_C 1.4
Build ID: 20140820003001
Gaia: 4f92950e6d96326785a249e8acb704da3647616b
Gecko: e1de5a959089
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Actual Results: Expected results appear for search query and are appropriately highlighted. Note that highlighting search results feature is not implemented on 1.4.

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Please add the regression keyword and provide a logcat.

Comment 7

[[:RJ]]

Attachment: contactlogcat

Comment 8

[KTucker [:KTucker][Inactive 3/4/2016]]

This is a regression from 2.0. Nominating 2.1? since the matching letters are not being highlighted and only one matching contact is shown even though there are several contacts that meet the search criteria.

Comment 9

[Joshua Mitchell (Inactive)]

Mozilla-Central Regression Window

Central Last Working:
Device: Flame 2.1 Master
BuildID: 20140814005107
Gaia: 5e074831f9ddacdf6f622a6dffaecb626f740be8
Gecko: 5299864050ee
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Central First Broken:
Device: Flame 2.1 Master
BuildID: 20140814125804
Gaia: c7f8938522a18454809fb6ea0fd3eddef10a73ea
Gecko: 68ab34bc1c77
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Gaia/Gecko swaps:
First broken gecko/Last working gaia - Issue DOES NOT reproduce
Gaia: 5e074831f9ddacdf6f622a6dffaecb626f740be8
Gecko: 68ab34bc1c77
First broken gaia/Last working gecko - Issue DOES reproduce
Gaia: c7f8938522a18454809fb6ea0fd3eddef10a73ea
Gecko: 5299864050ee

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/5e074831f9ddacdf6f622a6dffaecb626f740be8...c7f8938522a18454809fb6ea0fd3eddef10a73ea

---------------------------------------

B2G Inbound Last Working:
Device: Flame Master
Build ID: 20140814005707
Gaia: e91b3d740a90996c492c0a72443cc61eaa741099
Gecko: a9a8bb2c8704
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

B2G Inbound First Broken:
Device: Flame Master
Build ID: 20140814014706
Gaia: 9f7edfbd1d10a210835bc060c80b9556fe772641
Gecko: 509996a5a8a4
Version: 34.0a1 (Master)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Gaia/Gecko Swap:
First broken gecko/Last working gaia - Issue does NOT reproduce
Gaia: e91b3d740a90996c492c0a72443cc61eaa741099
Gecko: 509996a5a8a4
First broken gaia/Last working gecko - Issue DOES reproduce
Gaia: 9f7edfbd1d10a210835bc060c80b9556fe772641
Gecko: a9a8bb2c8704

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/e91b3d740a90996c492c0a72443cc61eaa741099...9f7edfbd1d10a210835bc060c80b9556fe772641

Possibly broken by: [Contacts] Search results highlighting does not work properly with sp…

Comment 10

[Adrián de la Rosa]

I'll take it because everything seems to point to a regression provoked by one of my patches. I will start looking for the problem right now.

Comment 11

[Adrián de la Rosa]

Attachment: 23627.html

Comment 12

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8482673 [details]
23627.html

LGTM although a double review here would be interesting. Also, could you check in some unit test that the class name is added to the two DOM elements? Ask again once addressed it. Thanks

Comment 13

[Adrián de la Rosa]

Comment on attachment 8482673 [details]
23627.html

Test added to check that shared/pages/import/import.html has at least one element with the right class. Is this similar to what you suggested?

Comment 14

[Cristian Rodriguez (:crdlc)]

Perfect! So if somebody changes the markup it will fail, thanks a lot

Comment 15

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

blocking, as it's identifiable regression

Comment 16

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8482673 [details]
23627.html

LGTM as I said and more with unit test

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482673 [details]
23627.html

Working perfectly, thanks folks for the work

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/mozilla-b2g/gaia/commit/9e863e957416c039c674d7d36f5a925b9c99fe93

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8482673 [details]
23627.html

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Regression while fixing standard search highlight

[User impact] if declined:
User wont be able to search contacts to import from facebook, gmail or hotmail

[Testing completed]:
Unit tests created for this patch, passing, manual smoke test done.

[Risk to taking this patch] (and alternatives if risky):
Low risk, really small patch with more unit tests than code modified

[String changes made]:
None

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/1a56ffd0a5c2757506c1948b45a38508cf5b5d8f

Comment 21

[John Thomas [:Johnt]]

This issue does NOT occur on the Flame 2.2 Master (319mb) and the Flame 2.1 KK (319mb)

Flame 2.2 Master KK (319mb) (Full Flash)

Device: Flame 2.2 Master
BuildID: 20141011040204
Gaia: 95f580a1522ffd0f09302372b78200dab9b6f322
Gecko: 3f6a51950eb5
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 35.0a1 (2.2 Master)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:35.0) Gecko/35.0 Firefox/35.0

Flame 2.1 KK (319mb) (Full Flash)

Device: Flame 2.1
BuildID: 20141011000201
Gaia: f5d4ff60ffed8961f7d0380ada9d0facfdfd56b1
Gecko: d813d79d3eae
Gonk: 52c909e821d107d414f851e267dedcd7aae2cebf
Version: 34.0a2 (2.1)
Firmware: V180
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result: Importing contacts search function is working correctly.