Closed Bug 1056308 Opened 7 years ago Closed 7 years ago

'get next' jobs panel doesn't seem applicable on single resultset view

Categories

(Tree Management :: Treeherder, defect, P4)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

References

()

Details

Attachments

(1 file)

When viewing an individual result set like
https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-central&revision=cbbc380f1e1c

The "get next |10|20|50|" footer panel, doesn't seem applicable or needed?

Maybe I'm missing some functionality. But clicking on it appears to cause some request for data and a fleeting percentage done bar, but no content change.
Priority: -- → P5
Priority: P5 → P4
I have a basic fix for this. Even so, the footer panel will draw fleetingly during a single resultset page load like it always has and does in production. I'm not sure how to improve that further at this time. The key part is once the page is loaded, the 'get next' UI is suppressed - which addresses the bug. I will open a PR shortly.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attached file treeherder-ui-PR#128
Please see the above PR for review and status.
The fleeting draw issue above, has not appeared in later local testing. Merged in master
https://github.com/mozilla/treeherder-ui/commit/58eddba303b53eee654c1dae7e9f612e92612176

I will mark fixed once it's pushed and tested on dev/stage.
Appears to be fixed and working correctly on dev. Marking fixed prior to push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Depends on: 1078209
You need to log in before you can comment on or make changes to this bug.