1056315 - Tabs panel animation does not get triggered the first time

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Federico Paolinelli]

Found this while working on bug 909434
The first time tabs panel gets by pressing the button on the toolbar, the tabs panel do not animate but appears in its final place. After the first time, the animation works properly and the panel gets translated / shaded.

Comment 1

[Federico Paolinelli]

Attachment: bug-1056315-fix

Since it was pretty easy to fix, here is the patch. I guess this behaviour was introduced with bug 852595 (which is why I am asking review? to capella and nalexander).
I also set the alpha value of tabs panel to 0, which is something that was not done even before the changes introduced in bug 852595, but I think should add a bit of consistency.

Comment 2

[Mark Capella [:capella]]

Comment on attachment 8476253 [details] [diff] [review]
bug-1056315-fix

Review of attachment 8476253 [details] [diff] [review]:
-----------------------------------------------------------------

It's subtle, and only on the first time the browser opens. This lgtm.

Comment 3

[Mark Capella [:capella]]

Comment on attachment 8476253 [details] [diff] [review]
bug-1056315-fix

Review of attachment 8476253 [details] [diff] [review]:
-----------------------------------------------------------------

heh - flipped the flag wrong

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Mark Capella [:capella] from comment #2)
> Comment on attachment 8476253 [details] [diff] [review]
> bug-1056315-fix
> 
> Review of attachment 8476253 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It's subtle, and only on the first time the browser opens. This lgtm.

Sure is.  For the next person: when you tap the tab counter icon, this animates the header with the tabs/private tabs/synced tabs/+ row, the first time.

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8476253 [details] [diff] [review]
bug-1056315-fix

Review of attachment 8476253 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.  Perhaps change the commit message to be closer to the ticket:

Bug 1056315 - Animate tab panel header on first tabs panel open. r=nalexander

Thanks for your feedback, capella -- this could be r=capella :)

Comment 6

[Federico Paolinelli]

Attachment: bug-1056315-fix

Here we go, I just changed the message. 
The bug was really subtle, I found it only because I was in paranoid mode looking for strange behaviours for the other bug, otherwise I would have not noticed it. Thanks for reviewing it.

Comment 7

[Federico Paolinelli]

PS: can I mark this as checkin-needed?

Comment 8

[Nick Alexander :nalexander [he/him]]

(In reply to Federico Paolinelli from comment #7)
> PS: can I mark this as checkin-needed?

Absolutely!  sheriffs, this is tiny and has had a local tester so I don't feel the need for a try build.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/e3bcab3975d5

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e3bcab3975d5