1056380 - pagemod attached multiple times to the same window

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P2)

Description

[Tomislav Jovanovic :zombie]

if i change this line:

https://github.com/mozilla/addon-sdk/blob/master/test/test-page-mod.js#L580

from:

  tab.close(done);

to:

  setTimeout(_ => tab.close(done), 100);

i see two assert passes reported..

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If this is more important than P2, feel free to increase the priority. 

Also, feel free to fix it. ;)

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1661

Comment 3

[Tomislav Jovanovic :zombie]

> If this is more important than P2, feel free to increase the priority. 
i'm been confused by bug priorities recently..

> Also, feel free to fix it. ;)
i have to since that test fails in e10s, and is blocking bug 1058698..

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8496581 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1661

Comments in the PR, but r+, looks good!

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/4c06efff6275dc6c549f435a033d00c72d58c750
bug 1056380 - avoid double-attach

https://github.com/mozilla/addon-sdk/commit/aace80d9564cbb546380cec4463c81b1073cfbd9
Merge pull request #1661 from zombie/1056380-double-attach

bug 1056380 - prevent double-attach, r=@jsantell