Closed Bug 1056452 Opened 6 years ago Closed 6 years ago

Make MediaSource::GetBuffered more readable w.r.t the spec algorithm, and improve logging of TimeRanges.

Categories

(Core :: Audio/Video, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: kinetik, Assigned: kinetik)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Catch null task queue with early assert.

SubBufferDecoder can hold an AbstractMediaDecoder if NotifyDataArrived is added to the interface.  This saves passing "this" to MediaSourceReader::CreateSubDecoder.

Improve logging of TimeRanges.
Attached patch patch v0Splinter Review
Make GetBuffered more readable wrt spec algorithm.  Improve logging of TimeRanges.  Add some asserts.  Add NotifyDataAvailable to AbstractMediaDecoder so SourceBuffer can hold an AbstractMediaDecoder.
Attachment #8476438 - Flags: review?(cajbir.bugzilla)
Blocks: MSE
Attachment #8476438 - Flags: review?(cajbir.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/151a4beda6ef
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.