1056518 - [Email][QuickToTop] The wording is not correct in New message banner

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P3)

Description

[Edward Chen[:edchen]]

Attachment: The wording is not correct

[Device]
Flame

[Environment]
Gaia      3584b2723412ed3299c6761f465885d80651c87e
Gecko     https://hg.mozilla.org/mozilla-central/rev/e7806c9c83f3
BuildID   20140820160201
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[STR]
1. Open email app
2. Set up a valid email account and set auto sync 5 mins
3. Send a mail to this account
4. Wait for 5 mins
5. The new message banner is appear.

[Actual result]
The wording is "# New Emails"

[Expected result]
The wording is "# New Messages"

Comment 1

[James Burke [:jrburke]]

Asking Stephany for confirmation on the casing and wording confirmation for this one too:

When showing the "3 New Messages" in the top bar overlay when new messages are added to the message list, it should be title cased as shown, and "Messages" should be used instead of "Emails" since the other mentions in the message list use the "Messages" terminology (like at the bottom of the message list where it has "Load More Messages" and "Loading Messages").

The related UX spec for this feature is in bug 989810 comment 2.

Comment 2

[Stephany Wilkes]

Flagging Rob to confirm the strings for FL, but James I believe you are correct. 

Sorry - we really need to be more diligent about strings and copy and specs. Fortunately we have an updated copy style guide in progress that will be ready SOON for our team.

Comment 3

[Rob MacDonald [:robmac]]

(In reply to James Burke [:jrburke] from comment #1)
> Asking Stephany for confirmation on the casing and wording confirmation for
> this one too:
> 
> When showing the "3 New Messages" in the top bar overlay when new messages
> are added to the message list, it should be title cased as shown, and
> "Messages" should be used instead of "Emails" since the other mentions in
> the message list use the "Messages" terminology (like at the bottom of the
> message list where it has "Load More Messages" and "Loading Messages").
> 
> The related UX spec for this feature is in bug 989810 comment 2.

Juwei is the owner but, for the purposes of FL, I'll chime in and say that I agree with James - we want the wording to be consistent.

NI'ing Juwei just in case.

Comment 4

[Stephany Wilkes]

James, please feel free to land this in the meantime - no need to hold up landing on copy like this when Rob and I agree. Thanks! Sorry about the hot potato game here a bit.

Comment 5

[James Burke [:jrburke]]

Thanks all. I think it is also worth sorting how we treat the strings in the system notifications, the ones that show up outside of the app. Those strings still say "Emails" since "Messages" could be potentially confusing, what type, SMS, some other chat app? But I am open for getting different longer term guidance.

For this ticket, which I want to land today, I will use "Messages" for this in-app header overlay and leave the notifications as they have been all this time with mentioning "Emails".

Comment 6

[Juwei Huang[:juwei]]

Hi James, you're right.
It should use "# New Messages" as ux spec described in bug 989810 and align to the middle of the line.
Thank you!

Comment 7

[James Burke [:jrburke]]

Fixed by the commit in bug 1059499 comment 5.

Comment 8

[Edward Chen[:edchen]]

[Environment]
Gaia      fbb297c39aab5f17b179533d2a9a6c5166b2c197
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/fb5e796da813
BuildID   20140902160204
Version   34.0a2
ro.build.version.incremental=eng.cltbld.20140820.195518
ro.build.date=Wed Aug 20 19:55:28 EDT 2014


[Result]
PASS