1056786 - Use EmulateStateOf to for ArrayState manipulation.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Use EmulateStateOf with an ArrayMemoryView.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8476640 [details] [diff] [review]
Use EmulateStateOf with an ArrayMemoryView.

Review of attachment 8476640 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, nice refactoring!

::: js/src/jit/ScalarReplacement.cpp
@@ +659,5 @@
> +    MConstant *undefinedVal_;
> +    MConstant *length_;
> +    MInstruction *arr_;
> +    MBasicBlock *startBlock_;
> +    BlockState *state_;

Do you think it'd be worth adding a common base class for this class and ObjectMemoryView, and moving these members into it?

Comment 3

[Nicolas B. Pierron [:nbp]]

(In reply to Jan de Mooij [:jandem] from comment #2)
> ::: js/src/jit/ScalarReplacement.cpp
> @@ +659,5 @@
> > +    MConstant *undefinedVal_;
> > +    MConstant *length_;
> > +    MInstruction *arr_;
> > +    MBasicBlock *startBlock_;
> > +    BlockState *state_;
> 
> Do you think it'd be worth adding a common base class for this class and
> ObjectMemoryView, and moving these members into it?

Hum … right we could share the startBlock and the undefinedVal initialization, but we would need a common interface to on the variable parts of the block states.  Still, I think it makes sense, but I don't think it make sense for AliasAnalysis to have it in EmulateStateOf, as alias analysis is dealing with multiple objects at once.

Comment 4

[Nicolas B. Pierron [:nbp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0dd7f70b560

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d0dd7f70b560