1056792 - Make enable_perproduct_builds opt out rather than opt in

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Ed Morley [:emorley]]

I believe enable_perproduct_builds should be set on most repos, so we should be making it opt out rather than opt in.

At least for now, we should keep it disabled for try etc - bug 1056790 will handle that.

So we should opt out for:
* try
* gaia-try
* ash (since used to test changes outside of gecko)
* cypress (ditto)
* cedar (ditto)

Comment 1

[Massimo Gervasini [:massimo]]

Attachment: [buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

make enable_perproduct_builds enabled by default

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: [buildbot-configs] Bug 1056792 - explicitly set enable_perproduct_builds.patch

Set enable_perproduct_build => 'False' on:

* try
* ash
* cedar
* cypress

and 'True' for all the other branches.

Even if we will have an opt-in mechanism, I'd prefer to have enable_perproduct_builds explicit.

Comment 3

[Chris AtLee [:catlee]]

Comment on attachment 8485693 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Review of attachment 8485693 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ -1430,1 @@
>              if not config.get('enable_perproduct_builds'):

I think we can just add True as the default value for config.get here.

Comment 4

[Massimo Gervasini [:massimo]]

Attachment: [buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Thanks Chris.

code updated.

Comment 5

[Massimo Gervasini [:massimo]]

Attachment: [buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 8487924 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Review of attachment 8487924 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ +1426,5 @@
>          else:
> +            # The per-product build behaviour is tweakable per branch, and
> +            # by default is opt-out. (Bug 1056792).
> +            if not config.get('enable_perproduct_builds', True):
> +                fileIsImportant = makeImportantFunc(config['hgurl'], True)

why are you changing None to True in makeImportantFunc?

Comment 7

[Massimo Gervasini [:massimo]]

Attachment: [buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Comment 8

[Simone Bruno [:simone]]

In prod with reconfig on 2014-09-15 08:30 PT

Comment 9

[Massimo Gervasini [:massimo]]

Attachment: [buildbot-configs] Bug 1056792 - disable per product builds on ash, cedar and cypress.patch

Set enable_perproduct_builds = False for ash, cedar and cypress