Closed Bug 1056792 Opened 7 years ago Closed 7 years ago

Make enable_perproduct_builds opt out rather than opt in

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: massimo)

References

Details

(Keywords: sheriffing-P1, Whiteboard: [capacity])

Attachments

(2 files, 4 obsolete files)

I believe enable_perproduct_builds should be set on most repos, so we should be making it opt out rather than opt in.

At least for now, we should keep it disabled for try etc - bug 1056790 will handle that.

So we should opt out for:
* try
* gaia-try
* ash (since used to test changes outside of gecko)
* cypress (ditto)
* cedar (ditto)
Assignee: nobody → mgervasini
make enable_perproduct_builds enabled by default
Attachment #8485693 - Flags: review?(catlee)
Set enable_perproduct_build => 'False' on:

* try
* ash
* cedar
* cypress

and 'True' for all the other branches.

Even if we will have an opt-in mechanism, I'd prefer to have enable_perproduct_builds explicit.
Attachment #8485732 - Flags: feedback?(catlee)
Comment on attachment 8485693 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Review of attachment 8485693 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ -1430,1 @@
>              if not config.get('enable_perproduct_builds'):

I think we can just add True as the default value for config.get here.
Attachment #8485693 - Flags: review?(catlee) → review-
Thanks Chris.

code updated.
Attachment #8485693 - Attachment is obsolete: true
Attachment #8487052 - Flags: review?(catlee)
Attachment #8487052 - Attachment is obsolete: true
Attachment #8487052 - Flags: review?(catlee)
Attachment #8487924 - Flags: review?(catlee)
Comment on attachment 8487924 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Review of attachment 8487924 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ +1426,5 @@
>          else:
> +            # The per-product build behaviour is tweakable per branch, and
> +            # by default is opt-out. (Bug 1056792).
> +            if not config.get('enable_perproduct_builds', True):
> +                fileIsImportant = makeImportantFunc(config['hgurl'], True)

why are you changing None to True in makeImportantFunc?
Attachment #8487924 - Flags: review?(catlee) → review-
Attachment #8488042 - Flags: review?(catlee) → review+
Attachment #8488042 - Flags: checked-in+
In prod with reconfig on 2014-09-15 08:30 PT
Set enable_perproduct_builds = False for ash, cedar and cypress
Attachment #8485732 - Attachment is obsolete: true
Attachment #8485732 - Flags: feedback?(catlee)
Attachment #8493120 - Flags: review?(rail)
Attachment #8493120 - Flags: review?(rail) → review+
Attachment #8493120 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.