Make enable_perproduct_builds opt out rather than opt in

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: massimo)

Tracking

({sheriffing-P1})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [capacity])

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

3 years ago
I believe enable_perproduct_builds should be set on most repos, so we should be making it opt out rather than opt in.

At least for now, we should keep it disabled for try etc - bug 1056790 will handle that.

So we should opt out for:
* try
* gaia-try
* ash (since used to test changes outside of gecko)
* cypress (ditto)
* cedar (ditto)
(Assignee)

Updated

3 years ago
Assignee: nobody → mgervasini
(Assignee)

Comment 1

3 years ago
Created attachment 8485693 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

make enable_perproduct_builds enabled by default
Attachment #8485693 - Flags: review?(catlee)
(Assignee)

Comment 2

3 years ago
Created attachment 8485732 [details] [diff] [review]
[buildbot-configs] Bug 1056792 - explicitly set enable_perproduct_builds.patch

Set enable_perproduct_build => 'False' on:

* try
* ash
* cedar
* cypress

and 'True' for all the other branches.

Even if we will have an opt-in mechanism, I'd prefer to have enable_perproduct_builds explicit.
Attachment #8485732 - Flags: feedback?(catlee)
Comment on attachment 8485693 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Review of attachment 8485693 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ -1430,1 @@
>              if not config.get('enable_perproduct_builds'):

I think we can just add True as the default value for config.get here.
Attachment #8485693 - Flags: review?(catlee) → review-
(Assignee)

Comment 4

3 years ago
Created attachment 8487052 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Thanks Chris.

code updated.
Attachment #8485693 - Attachment is obsolete: true
Attachment #8487052 - Flags: review?(catlee)
(Assignee)

Comment 5

3 years ago
Created attachment 8487924 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch
Attachment #8487052 - Attachment is obsolete: true
Attachment #8487052 - Flags: review?(catlee)
Attachment #8487924 - Flags: review?(catlee)
Comment on attachment 8487924 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch

Review of attachment 8487924 [details] [diff] [review]:
-----------------------------------------------------------------

::: misc.py
@@ +1426,5 @@
>          else:
> +            # The per-product build behaviour is tweakable per branch, and
> +            # by default is opt-out. (Bug 1056792).
> +            if not config.get('enable_perproduct_builds', True):
> +                fileIsImportant = makeImportantFunc(config['hgurl'], True)

why are you changing None to True in makeImportantFunc?
Attachment #8487924 - Flags: review?(catlee) → review-
(Assignee)

Comment 7

3 years ago
Created attachment 8488042 [details] [diff] [review]
[buildbotcustom] Bug 1056792 - Make enable_perproduct_builds opt out rather than opt in.patch
Attachment #8487924 - Attachment is obsolete: true
Attachment #8488042 - Flags: review?(catlee)

Updated

3 years ago
Attachment #8488042 - Flags: review?(catlee) → review+
(Assignee)

Updated

3 years ago
Attachment #8488042 - Flags: checked-in+
In prod with reconfig on 2014-09-15 08:30 PT
(Assignee)

Comment 9

3 years ago
Created attachment 8493120 [details] [diff] [review]
[buildbot-configs] Bug 1056792 - disable per product builds on ash, cedar and cypress.patch

Set enable_perproduct_builds = False for ash, cedar and cypress
Attachment #8485732 - Attachment is obsolete: true
Attachment #8485732 - Flags: feedback?(catlee)
Attachment #8493120 - Flags: review?(rail)
Attachment #8493120 - Flags: review?(rail) → review+
(Assignee)

Updated

3 years ago
Attachment #8493120 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.