1056842 - shared MockPromise

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

While working on bug 1029951 I spent days trying to test this code step by step:

      this._startDownload()
        .then(function(data) {
          this.state = this.STATE_LOADING;
          this._updateUI();

          return data;
        }.bind(this))
        .then(this._insertIntoDatabase.bind(this))
        .then(function() {
          this.state = this.STATE_LOADED;
          this._updateUI();
        }.bind(this))
        .catch(function(e) {
          this.state = this.STATE_DOWNLOADABLE;
          this._updateUI();

          e && console.error(e);
        }.bind(this));

I ended up mock the Promise interface with a fairly non-trival, but fortunately reusable code, so I figured I should just moved it to shared/js/.

Comment 1

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#23154

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8476698 [details] [review]
mozilla-b2g:master PR#23154

Sam, would you mind reviewing this? This is a MockPromise interface I ended up creating and I hope this is useful enough to be put into shared.

I was meant to ask both you and Julien for feedback, but he is on PTO.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8476698 [details] [review]
mozilla-b2g:master PR#23154

This looks good to me, I ran the tests and poked around. I can see it being useful when wanting to test a particular part of a promise chain, or to ensure errors reach error handlers at the end of a promise chain perhaps.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks!

master: https://github.com/mozilla-b2g/gaia/commit/d687c5d7c6bb3ec6e748349ed12ec16a84c96464