1056884 - Implement special expanded Rocketbar state for homescreen and browser

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Ben Francis [:benfrancis]]

The Rocketbar should be expanded by default on the homescreen and the browser (search) app but it needs a special state with just "Search or enter address" placeholder text instead of the app title.

In this special state no navigation buttons should be displayed.

Comment 1

[Ben Francis [:benfrancis]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/23281

I've implemented this just for the browser start page as we don't yet have the real Rocketbar on homescreen.

I don't have the final assets for the search icon so have created placeholders by modifying the ones from the homescreen app. Eric, please let me know where I can find these so we can do an image swap later.

Comment 2

[Kevin Grandon :kgrandon]

Cool - I also have a marionette test which should provide some additional title coverage that we may want to add to once these both land.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8478475 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/23281

I am a bit concerned about the special casing spiraling out of control, but seems fine to land for now. Thanks!

Comment 4

[Ben Francis [:benfrancis]]

(In reply to Kevin Grandon :kgrandon from comment #3)
> I am a bit concerned about the special casing spiraling out of control, but
> seems fine to land for now. Thanks!

Yeah, I agree. In my review of v0.12 of the Rocketbar spec I noted that there were 8 different variations of Rocketbar defined for various special cases. We've now managed to negotiate it down to 5 but I think we can reduce that more (e.g. by implementing real Rocketbar on the homescreen).

Comment 5

[Ben Francis [:benfrancis]]

Integration tests are red on TBPL but seems unrelated, re-basing and pushing again.

Comment 6

[Eric Pang [:epang] UX]

(In reply to Ben Francis [:benfrancis] from comment #1)
> Created attachment 8478475 [details] [review]
> https://github.com/mozilla-b2g/gaia/pull/23281
> 
> I've implemented this just for the browser start page as we don't yet have
> the real Rocketbar on homescreen.
> 
> I don't have the final assets for the search icon so have created
> placeholders by modifying the ones from the homescreen app. Eric, please let
> me know where I can find these so we can do an image swap later.

Hey Ben,  I've added the search icons here on box:
https://mozilla.box.com/s/lh64n4krbkb9snuxnxcx

Let me know if anything else is needed.  Thanks!

Comment 7

[Ben Francis [:benfrancis]]

https://github.com/mozilla-b2g/gaia/commit/1c6bc15bfcc49a72658e2c841c214b9e5ad540fb