1056918 - LoopContacts should allow distinguishing between 'not found' and 'database error' programmatically

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Adam Roach [:abr]]

When a LoopContacts user attempts to retreive a contact, it should be able to
tell the difference between "that contact isn't in the database" and "an
attempt to access the database resulted in an exception or other error of some
kind" without examining error.message. Calling the callback with both "error"
and "contact" set to null conveys this unambiguously, and has the added
benefit of playing nicely with users who wrap the callback in a Promise.

(Semantically, this is sensical: "your search request succeeded, but did not
yield any results".)

Comment 1

[Adam Roach [:abr]]

Attachment: Allow distinguishing between 'not found' and 'database error' programmatically

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 8476773 [details] [diff] [review]
Allow distinguishing between 'not found' and 'database error' programmatically

Review of attachment 8476773 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=Standard8

Comment 3

[Adam Roach [:abr]]

https://hg.mozilla.org/integration/fx-team/rev/2b5bc470740d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2b5bc470740d

Comment 5

[u279076]

Looks like this landed with tests. Does this need QA?

Comment 6

[Adam Roach [:abr]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #5)
> Looks like this landed with tests. Does this need QA?

Probably not; this is just an API change, and the mochi tests check that the functional behavior is as expected.

Comment 7

[u279076]

Thanks Adam, untracked for verification.