1056941 - Fix GCC 4.9 compile errors

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

Fennec can compile under GCC 4.9 with small changes.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Fix dangerous destructors in Fennec code (v1)

We get a lot of "dangerous public destructor" errors when compiling with GCC 4.9. The concern is a public destructor for an XPCOM object can be called outside of Release(), and therefore can mess up reference counting. This patch refacors these classes to make affected destructors private.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Use setenv instead of putenv (v1)

GCC 4.9 complains about passing a string literal to putenv, which uses a (char*) argument. setenv uses (const char*) arguments, so setenv seems to be the correct call for string literals.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Disable unused local typedef warning in STLPort (v1)

GCC 4.9 complains about unused local typedefs in stlport used for static assertion.

Comment 4

[Mike Hommey [:glandium] (PTO. Back on Nov 25)]

Comment on attachment 8478460 [details] [diff] [review]
Use setenv instead of putenv (v1)

Review of attachment 8478460 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozglue/android/APKOpen.cpp
@@ +318,5 @@
>  
>  extern "C" NS_EXPORT void JNICALL
>  Java_org_mozilla_gecko_mozglue_GeckoLoader_loadSQLiteLibsNative(JNIEnv *jenv, jclass jGeckoAppShellClass, jstring jApkName, jboolean jShouldExtract) {
>    if (jShouldExtract) {
> +    setenv("MOZ_LINKER_EXTRACT", "1", true);

Looking at the calling code, there's actually no user of that branch anymore. Just remove the jShoudExtract argument entirely.

@@ +340,5 @@
>  
>  extern "C" NS_EXPORT void JNICALL
>  Java_org_mozilla_gecko_mozglue_GeckoLoader_loadNSSLibsNative(JNIEnv *jenv, jclass jGeckoAppShellClass, jstring jApkName, jboolean jShouldExtract) {
>    if (jShouldExtract) {
> +    setenv("MOZ_LINKER_EXTRACT", "1", true);

Likewise.

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 8478459 [details] [diff] [review]
Fix dangerous destructors in Fennec code (v1)

Review of attachment 8478459 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/components/build/nsShellService.h
@@ +19,3 @@
>  
>  private:
> +  ~nsShellService() {}

is this just ws change? if so, drop it.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/963b26a1a6fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b4012ce7676
https://hg.mozilla.org/integration/mozilla-inbound/rev/4354d5ed2311

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Remove extract libs parameter (v1)

Oops, I thought I got all r+'s so I landed all the patches. Here's the patch that removes the jShoudExtract argument. I'll backout the patch if it's not good.

Try: https://tbpl.mozilla.org/?tree=Try&rev=1b26432bdd1d

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/963b26a1a6fb
https://hg.mozilla.org/mozilla-central/rev/5b4012ce7676
https://hg.mozilla.org/mozilla-central/rev/4354d5ed2311