Backout Browser specific CSS rules for French from 2.0 to fix tabs in Browser

VERIFIED FIXED in Firefox OS v2.0

Status

Firefox OS
Gaia::Browser
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: tchevalier, Assigned: tchevalier)

Tracking

unspecified
2.1 S3 (29aug)
x86_64
Linux

Firefox Tracking Flags

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

Details

Attachments

(3 attachments)

Created attachment 8476869 [details]
Flame 2.1

[Blocking Requested - why for this release]:

Bug 1010537 added some specific CSS rules for French only.
While this avoid us a truncation on a tab on some screens, this is badly breaking the browser with 480 pxiels wide screens + x1.5 assets (Flame, ZTE Open C...) See attached screenshot.

Given that ZTE Open C will likely be updated to 2.0 in France and we won't remove the old browser in 2.0, we need to fix it ASAP.

I'll attach a PR right away.

There is absolutely no risks as it was code specific to French. We'll have a truncation, but I prefer a truncation to a broken browser.
Created attachment 8476994 [details] [review]
Link to Github PR

Hi Ben, any chance you can take a look at this easy one?
Assignee: nobody → tchevalier
Status: NEW → ASSIGNED
Attachment #8476994 - Flags: review?(bfrancis)
Comment on attachment 8476994 [details] [review]
Link to Github PR

Dale, as you added these I'd like to get your input before removing them again.
Attachment #8476994 - Flags: review?(bfrancis) → review?(dale)
Comment on attachment 8476994 [details] [review]
Link to Github PR

Yeh never liked these hacks
Attachment #8476994 - Flags: review?(dale) → review+
Thanks :)
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/1934a2297ffc0d90424cd9cd3294c4a8c74a7333
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-b2g-v2.1: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S3 (29aug)
Verified fixed on 2.1 Flame with:

Gaia      1934a2297ffc0d90424cd9cd3294c4a8c74a7333
Gecko     https://hg.mozilla.org/mozilla-central/rev/18901d4f3edd
BuildID   20140825160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230


Let's wait for 2.0 approval
Status: RESOLVED → VERIFIED
status-b2g-v2.0: --- → affected
Created attachment 8478804 [details]
Flame 2.1 fixed

Updated

4 years ago
blocking-b2g: 2.0? → 2.0+
You need to log in before you can comment on or make changes to this bug.