1056975 - Backout Browser specific CSS rules for French from 2.0 to fix tabs in Browser

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[Théo Chevalier]

Attachment: Flame 2.1

[Blocking Requested - why for this release]:

Bug 1010537 added some specific CSS rules for French only.
While this avoid us a truncation on a tab on some screens, this is badly breaking the browser with 480 pxiels wide screens + x1.5 assets (Flame, ZTE Open C...) See attached screenshot.

Given that ZTE Open C will likely be updated to 2.0 in France and we won't remove the old browser in 2.0, we need to fix it ASAP.

I'll attach a PR right away.

There is absolutely no risks as it was code specific to French. We'll have a truncation, but I prefer a truncation to a broken browser.

Comment 1

[Théo Chevalier]

Attachment: Link to Github PR

Hi Ben, any chance you can take a look at this easy one?

Comment 2

[Ben Francis [:benfrancis]]

Comment on attachment 8476994 [details] [review]
Link to Github PR

Dale, as you added these I'd like to get your input before removing them again.

Comment 3

[Dale Harvey (:daleharvey)]

Comment on attachment 8476994 [details] [review]
Link to Github PR

Yeh never liked these hacks

Comment 4

[Théo Chevalier]

Thanks :)

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/1934a2297ffc0d90424cd9cd3294c4a8c74a7333

Comment 6

[Théo Chevalier]

Verified fixed on 2.1 Flame with:

Gaia      1934a2297ffc0d90424cd9cd3294c4a8c74a7333
Gecko     https://hg.mozilla.org/mozilla-central/rev/18901d4f3edd
BuildID   20140825160203
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230


Let's wait for 2.0 approval

Comment 7

[Théo Chevalier]

Attachment: Flame 2.1 fixed

Comment 8

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/6450e069f6c9b6fd648b0c51577a2596157a3674