Closed Bug 1056976 Opened 7 years ago Closed 7 years ago

Follow-up: Increase height of HomePagerTabStrip

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 34

People

(Reporter: liuche, Assigned: lucasr)

References

Details

Attachments

(3 files)

Splitting this off from bug 1021751, because there seems to be an Android bug that affects the padding of the title strip such that text in the titlebar doesn't center vertically correctly.
Found it, PagerTabStrip sets a minimum padding bottom in order to ensure none of the children will be placed under the indicator. See:

https://github.com/android/platform_frameworks_support/blob/master/v4/java/android/support/v4/view/PagerTabStrip.java#L89
https://github.com/android/platform_frameworks_support/blob/master/v4/java/android/support/v4/view/PagerTabStrip.java#L151

The cleanest workaround here is to override getPaddingBottom() to return 0. Patch coming in a minute.
Comment on attachment 8477314 [details] [diff] [review]
Increate height of HomePagerTabStrip to 40dp (r=liuche)

I'm assuming the new height is 40dp here. Let me know if it's something else.
Attachment #8477314 - Flags: review?(liuche)
Comment on attachment 8477314 [details] [diff] [review]
Increate height of HomePagerTabStrip to 40dp (r=liuche)

Review of attachment 8477314 [details] [diff] [review]:
-----------------------------------------------------------------

Great! This is actually the exact patch I had in my queue too :)
Attachment #8477314 - Flags: review?(liuche) → review+
https://hg.mozilla.org/integration/fx-team/rev/cb24d9bb372e

Landed this patch because I want it to be with bug 1021751.
Assignee: nobody → lucasr.at.mozilla
Status: NEW → ASSIGNED
Target Milestone: --- → Firefox 34
https://hg.mozilla.org/mozilla-central/rev/cb24d9bb372e
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.