1056976 - Follow-up: Increase height of HomePagerTabStrip

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Chenxia Liu [:liuche]]

Attachment: Mock-up: Homepage design

Splitting this off from bug 1021751, because there seems to be an Android bug that affects the padding of the title strip such that text in the titlebar doesn't center vertically correctly.

Comment 1

[Lucas Rocha (:lucasr)]

Found it, PagerTabStrip sets a minimum padding bottom in order to ensure none of the children will be placed under the indicator. See:

https://github.com/android/platform_frameworks_support/blob/master/v4/java/android/support/v4/view/PagerTabStrip.java#L89
https://github.com/android/platform_frameworks_support/blob/master/v4/java/android/support/v4/view/PagerTabStrip.java#L151

The cleanest workaround here is to override getPaddingBottom() to return 0. Patch coming in a minute.

Comment 2

[Lucas Rocha (:lucasr)]

Attachment: Increate height of HomePagerTabStrip to 40dp (r=liuche)

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8477314 [details] [diff] [review]
Increate height of HomePagerTabStrip to 40dp (r=liuche)

I'm assuming the new height is 40dp here. Let me know if it's something else.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Screenshot for the record

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8477314 [details] [diff] [review]
Increate height of HomePagerTabStrip to 40dp (r=liuche)

Review of attachment 8477314 [details] [diff] [review]:
-----------------------------------------------------------------

Great! This is actually the exact patch I had in my queue too :)

Comment 6

[Chenxia Liu [:liuche]]

https://hg.mozilla.org/integration/fx-team/rev/cb24d9bb372e

Landed this patch because I want it to be with bug 1021751.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cb24d9bb372e