1056990 - [rule view] Highlight all nodes that match the hovered selector in the rule-view

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Patrick Brosset <:pbro>]

Same as bug 971662 but for the rule-view.

Hovering over any selector in the rule-view should highlight the matching nodes in the page.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: bug1056990-highlight-selectors-ruleview v1.patch

v1. Should work. And has tests.
Pending try build: https://tbpl.mozilla.org/?tree=Try&rev=b6bc27d86794

Comment 2

[Patrick Brosset <:pbro>]

I hope I didn't miss anything obvious ... I have a strange feeling, this patch took only 1 hour altogether and was surprisingly simple. I guess it's the recent refactors of the style-inspector and highlighter that pay off :)

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8476905 [details] [diff] [review]
bug1056990-highlight-selectors-ruleview v1.patch

Review of attachment 8476905 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is simple and works well.

If we do this in the rule view should also do it in the computed view.

Comment 4

[Patrick Brosset <:pbro>]

Thanks for the review Mike.
The patch doesn't make any assumption about which view the mouse is currently hovering over, so this could work with any other views that have selectors in them. The computed view doesn't though, so for now, it's only the rule-view.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/fd9c52c35d50

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fd9c52c35d50

Comment 7

[Patrick Brosset <:pbro>]

(In reply to Michael Ratcliffe [:miker] [:mratcliffe] from comment #3)
> If we do this in the rule view should also do it in the computed view.
Sorry, you were completely right, we do have selectors in the computed view. I'm going to file a new bug for this.