1057023 - [Calendar] Event Icons are not changed in months other than the selected one when enabling/disabling calendars

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat.txt

Description:
In the calendar app if the user has events occurring in multiple months, and they disable or enable the calendar these events are in, only the month that was actually being viewed will have the event indicators (dots, icons) affected correctly. 
If the calendar was disabled players will still see the indicators in other months. Selecting the days will not show the events. 
If the calendar was enabled then the other months will not have icons on the days of events. Selecting the days will show the events. 
If the user is viewing a day or week when the calendar is enabled/disabled it will only change the events on the last month that was viewed.

Repro Steps:
1) Update a Flame device to BuildID: 20140820040203
2) Open the calendar app
3) Add events in multiple months
4) Disable the calendar
5) Observe event icons in months other than the one that was selected
  
Actual:
Event Icons are not affected in other months when the calendar is disabled
  
Expected: 
It is expected that when the calendar is disabled you will not see event icons relevant to that calendar in month view.
  
Environmental Variables:
Device: Flame 2.1 Master (319mb)
BuildID: 20140820040203
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
  
Repro frequency: 100%
Link to failed test case: https://moztrap.mozilla.org/manage/case/2467/
See attached: video clip(http://youtu.be/ttd3L4t8ATE), logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue occurs in 2.1 Flame (512mb), 2.1 Open_C, 2.0 Flame, and 2.0 Open_C.

Environmental Variables:
Device: Flame 2.1 Master (512mb)
BuildID: 20140820040203
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0

Device: Flame 2.0 (319mb)
BuildID: 20140820000201
Gaia: 88db39a0826086024631049d83ae6aa397f0918d
Gecko: 2092ac87eceb
Version: 32.0 (2.0)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Device: Open_C Master
Build ID: 20140820040203
Gaia: df39c463259d348396ef7f143c2c780eeb8f02d8
Gecko: ffdd1a398105
Version: 34.0a1 (Master)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Device: Open_C 2.0
BuildID: 20140820000201
Gaia: 88db39a0826086024631049d83ae6aa397f0918d
Gecko: 2092ac87eceb
Version: 32.0 (2.0)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Result:
Event Icons are not affected in other months when the calendar is disabled

-------------------------------------------------------------------------
This issue does not occur in 1.4 Flame or 1.4 Open_C.

Environmental Variables:
Device: Flame 1.4 (319mb)
Build ID: 20140820003001
Gaia: 4f92950e6d96326785a249e8acb704da3647616b
Gecko: e1de5a959089
Version: 30.0 (1.4)
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Device: Open_C 1.4
Build ID: 20140820003001
Gaia: 4f92950e6d96326785a249e8acb704da3647616b
Gecko: e1de5a959089
Version: 30.0 (1.4)
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:30.0) Gecko/30.0 Firefox/30.0

Result:
The event icons were cleared for all months.

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

[Blocking Requested - why for this release]:

This is a regression from 1.4. Calendar events should not be showing for disabled accounts so nominating 2.0?

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

There is a bug in between our Last Working and First Broken builds that's preventing us from narrowing the window down. The bug is that when user adds an event to the Calendar, there isn't a dot icon on the Calendar indicating that there's an event on there. Therefore there is no way to tell if this bug 1057023 is repro'ing or not.

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20140515113003
Gaia: 7973e06dc278f67b4109ac3c33020ed086f0d042
Gecko: 15af5b93c0ea
Version: 32.0a1 (2.0 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20140516173002
Gaia: ed5d408dc1120b035ebce9a809499c30fbfb4582
Gecko: 93faf230139c
Version: 32.0a1 (2.0 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

First broken gecko & Last working gaia - issue does NOT repro
Gaia: 7973e06dc278f67b4109ac3c33020ed086f0d042
Gecko: 93faf230139c

First broken gaia & Last working gecko - issue DOES repro
Gaia: ed5d408dc1120b035ebce9a809499c30fbfb4582
Gecko: 15af5b93c0ea

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/7973e06dc278f67b4109ac3c33020ed086f0d042...ed5d408dc1120b035ebce9a809499c30fbfb4582

Possibly caused by Bug 951075 ?

Comment 4

[Joshua Mitchell (Inactive)]

Broken by Bug 951075 ? Can you take a look Miller?

Comment 6

[Miller Medeiros [:millermedeiros]]

We changed the toggle calendar logic on Bug 1016687 to fix a few issues but unfortunately the new logic introduced this undesired behavior.

I'm currently working on the new Week View (Bug 1023662), and during the process I ended up improving the toggle calendar logic (which should land this week and fix this problem).

If we need to uplift this to 2.0 I'll need to create a new patch containing just the toggle calendar changes.

Comment 7

[bhavana bajaj [:bajaj]]

Given this is a regression , very bad UX and might confuse the end user blocking on this. PLease NI me if the patch being uplifted is too risky so we can get more targeted testing here.

Comment 8

[Miller Medeiros [:millermedeiros]]

This was fixed on 2.1 by the 5-day week view patch (Bug 1023662). Will provide a separate patch for v2.0 soon.

Comment 9

[Miller Medeiros [:millermedeiros]]

Attachment: [v2.0] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23386

this patch is only for the v2.0 branch, I added an integration test to make sure behavior was fixed and also to avoid regressions (test was failing before my patch).

It's exactly the same logic that I had on the 5-day week view patch (only the marionette test that is new).

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8480130 [details] [review]
[v2.0] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23386

Awesome... only have one whitespace nit

Comment 11

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8480130 [details] [review]
[v2.0] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23386

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1016687
[User impact] if declined: it will look like toggle calendar feature is broken, since it doesn't affect events on other months.
[Testing completed]: marionette and manual testing
[Risk to taking this patch] (and alternatives if risky): low
[String changes made]: none

Comment 12

[bhavana bajaj [:bajaj]]

Comment on attachment 8480130 [details] [review]
[v2.0] Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23386

QA, Please verify once this lands on 2.0

Comment 13

[Gareth Aye [:gaye] (back from PTO)]

Landed on master https://github.com/mozilla-b2g/gaia/commit/f02a8e4ef0fabeb28593fa660a0a4ca8a5fe67e5

Comment 14

[Gareth Aye [:gaye] (back from PTO)]

%s/master/2.0/ sorry haha

Comment 15

[Edward Chen[:edchen]]

[Environment]
Gaia      e731a63484c532168f4de6dc1eeb4c6612ad73a9
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/868cc9e5e32a
BuildID   20140915160206
Version   34.0a2
ro.build.date   Fri Jun 27 15:57:58 CST 2014
ro.bootloader   L1TC00011230
ro.build.version.incremental   110


[Result]
PASS

Comment 16

[Mike Lien[:mlien]]

verify with Flame v180 + v2.0 gaia/gecko, it's fine
Gaia      7edd3b0b9f65c3dde235c732d270e43e055a1254
Gecko     https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/f3639e825b3b
BuildID   20140915135336
Version   32.0

Comment 17

[Coler]

This issue has been verified successfully on Flame2.1.
Reproducing rate: 0/5
See attachment: Verify_Flame_Calendar.mp4

Flame2.1 build version:
Gaia-Rev        38e17b0219cbc50a4ad6f51101898f89e513a552
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8b92c4b8f59a
Build-ID        20141205001201
Version         34.0

Comment 18

[Coler]

Attachment: Verfiy_Flame_Calendar.MP4