1057044 - [mozrunner] Remove minidumps from device after pulling them for crash detection

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

After pulling the minidumps folder from the device it is removed, which is preventing any further minidumps from being written to it. We should only remove the contents of this folder instead.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Remove minidumps from device after pulling them for crash detection. v1.0

Try run: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5cc91b910718

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8476937 [details] [diff] [review]
Remove minidumps from device after pulling them for crash detection. v1.0

Review of attachment 8476937 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good! r+, with one nit.

::: testing/mozbase/mozrunner/mozrunner/devices/base.py
@@ +61,5 @@
>          remote_dump_dir = posixpath.join(self.app_ctx.remote_profile, 'minidumps')
>          local_dump_dir = tempfile.mkdtemp()
>          self.dm.getDirectory(remote_dump_dir, local_dump_dir)
> +        for f in self.dm.listFiles(remote_dump_dir):
> +            self.dm.removeFile('/'.join([remote_dump_dir, f]))

nit: use 'posixpath.join' here

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Remove minidumps from device after pulling them for crash detection. v1.1

Carrying r+

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f66f7b5533f9

Comment 5

[Henrik Skupin (:whimboo) [⌚️UTC+2]]

(In reply to Dave Hunt (:davehunt) from comment #0)
> After pulling the minidumps folder from the device it is removed, which is
> preventing any further minidumps from being written to it. We should only
> remove the contents of this folder instead.

That's interesting. Shouldn't we better re-create that folder? Ted, do you know about that?

Comment 6

[(not currently active) Ted Mielczarek]

It ought to be created on startup, but it's possible you're just hitting a race condition with the app restarting, deleting it after it checks for it. Don't delete the folder, just delete the minidumps.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f66f7b5533f9