Closed
Bug 1057119
Opened 11 years ago
Closed 11 years ago
High cache failure rate with sccache
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla34
People
(Reporter: glandium, Assigned: glandium)
Details
Attachments
(3 files)
|
1.42 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
|
162.58 KB,
application/x-bzip2
|
Details | |
|
9.61 KB,
patch
|
mshal
:
review+
|
Details | Diff | Splinter Review |
Turns out the high failure rate mentioned in bug 1055872 is due to this line:
https://github.com/glandium/sccache/blob/4d312f8b9a42012acbef0d9ffba1e6f46de4fd18/storage.py#L253
combined with boto reusing HTTPConnection objects.
| Assignee | ||
Comment 1•11 years ago
|
||
Note that's been there since the beginning:
https://github.com/glandium/sccache/blob/115016e0a83b290dc2dbb366127499fb09168707/sccache.py#L35
| Assignee | ||
Comment 2•11 years ago
|
||
Attachment #8477088 -
Flags: review?(mshal)
| Assignee | ||
Comment 3•11 years ago
|
||
| Assignee | ||
Comment 4•11 years ago
|
||
(6938a9b is the local sha1 for the sccache commit corresponding to the already attached patched, with r=mshal in the commit message)
Attachment #8477096 -
Flags: review?(mshal)
Updated•11 years ago
|
Attachment #8477088 -
Flags: review?(mshal) → review+
Updated•11 years ago
|
Attachment #8477096 -
Flags: review?(mshal) → review+
| Assignee | ||
Comment 5•11 years ago
|
||
| Assignee | ||
Comment 6•11 years ago
|
||
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•