Closed Bug 1057127 Opened 5 years ago Closed 5 years ago

[a11y] Improve accessibility of output area for screen readers

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
Firefox 34

People

(Reporter: Jamie, Assigned: Jamie)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

Spun off bug 977267.

Currently, screen reader users have to actively review the console output area to see any new output. This is particularly tedious when you want to know the result of a command typed into the console. Also, the output area is focusable, as are any links, but the individual items aren't focusable. This probably makes sense, but it means reviewing the output requires use of screen reader review commands, which can be tedious.
Attached patch Patch (obsolete) — Splinter Review
This patch:
* Removes tabindex="0" on the output area so it at least ends up in the same spot as its links.
* Gives the output area role="document" so ATs will treat it like a document.
* Makes the output area a live region so new content will be reported automatically by screen readers.
* As an exception to the live region, input from the user is not reported automatically (aria-live="off"), as the user doesn't want content they just entered to be echoed. Note that this won't currently work with NVDA due to a bug in NVDA, but you can confirm it by poking at the attributes on a piece of input.

Marco, requesting feedback on the role="document", tabindex="0" and aria-live="off" bits.
Assignee: nobody → jamie
Status: NEW → ASSIGNED
Attachment #8477075 - Flags: feedback?(marco.zehe)
Comment on attachment 8477075 [details] [diff] [review]
Patch

This works absolutely fabulously! A very nice user experience when shift-tabbing from the input field. Also, the feedback via live region and auto-complete (combined this with bug 977267) is absolutely fantastic! Good job!
Attachment #8477075 - Flags: feedback?(marco.zehe) → feedback+
Attachment #8477075 - Flags: review?(rcampbell)
Comment on attachment 8477075 [details] [diff] [review]
Patch

Redirecting review request as per discussion on IRC.
Attachment #8477075 - Flags: review?(rcampbell) → review?(bgrinstead)
Comment on attachment 8477075 [details] [diff] [review]
Patch

Review of attachment 8477075 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - please add a commit message on the patch to the effect of 'Bug 1057127 - [a11y] Improve accessibility of console output area for screen readers;r=bgrins'

::: browser/devtools/webconsole/webconsole.xul
@@ +173,5 @@
>                   placeholder="&filterOutput.placeholder;" tabindex="2"/>
>        </toolbar>
>  
>        <hbox id="output-wrapper" flex="1" context="output-contextmenu" tooltip="aHTMLTooltip">
> +        <div xmlns="http://www.w3.org/1999/xhtml" id="output-container" tabindex="0" role="document" aria-live="polite" />

Nit: line up attributes on a new line once the previous line has gone over 80 chars (see <textbox> below for an example).
Attachment #8477075 - Flags: review?(bgrinstead) → review+
Thanks! Address nit from review (comment 4).

Btw, should I carry review and feedback forward to the new patch when I fix nits?
Attachment #8477075 - Attachment is obsolete: true
Keywords: checkin-needed
(In reply to James Teh [:Jamie] from comment #5)
> Created attachment 8478773 [details] [diff] [review]
> Patch for checkin
> 
> Thanks! Address nit from review (comment 4).
> 
> Btw, should I carry review and feedback forward to the new patch when I fix
> nits?

Yes, you can carry the r+ over
Attachment #8478773 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/e599d103be3f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Verifying from feedback in Comment 2.
Status: RESOLVED → VERIFIED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.