1057174 - [WebRTC] |DesktopDeviceInfoImpl::initializ| in desktop_device_info.cc use wrong argument while calling snprintf.

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

|DesktopDeviceInfoImpl::initializ| in desktop_device_info.cc use wrong argument while calling snprintf. It will cause mochitest fail in local linux machine(but tbpl pass.) I found this bug when I ran mochitest for Bug 1053130.

Comment 1

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Attachment: bug-1057174.patch v1.0

Comment 2

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

Comment on attachment 8477124 [details] [diff] [review]
bug-1057174.patch v1.0

Review of attachment 8477124 [details] [diff] [review]:
-----------------------------------------------------------------

Hi, Randell,
Could you please review this patch?

Comment 3

[Chia-hung Tai [:ctai :ctai_mozilla :cht]]

TBPL result:
https://tbpl.mozilla.org/?tree=Try&rev=f91e67928553

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6ddd42718dc

In future, please try to use a commit message that summarizes what the patch is doing rather than restating the problem it's fixing. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e6ddd42718dc

Comment 6

[Wolfgang Rosenauer [:wolfiR]]

This is failing to build for me on mozilla-beta (FF33):

[ 1396s] In function 'int snprintf(char*, size_t, const char*, ...)',
[ 1396s]     inlined from 'int32_t webrtc::DesktopDeviceInfoImpl::initializeWindowList()' at /home/abuild/rpmbuild/BUILD/mozilla/media/webrtc/trunk/webrtc/modules/desktop_capture/desktop_device_info.cc:245:71:
[ 1396s] /usr/include/bits/stdio2.h:65:44: warning: call to int __builtin___snprintf_chk(char*, long unsigned int, int, long unsigned int, const char*, ...) will always overflow destination buffer [enabled by default]

So I guess this should land in 33?

Comment 7

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 8477124 [details] [diff] [review]
bug-1057174.patch v1.0

Building with certain compiler checks enabled warns about:

[ 1396s] In function 'int snprintf(char*, size_t, const char*, ...)',
[ 1396s]     inlined from 'int32_t webrtc::DesktopDeviceInfoImpl::initializeWindowList()' at /home/abuild/rpmbuild/BUILD/mozilla/media/webrtc/trunk/webrtc/modules/desktop_capture/desktop_device_info.cc:245:71:
[ 1396s] /usr/include/bits/stdio2.h:65:44: warning: call to int __builtin___snprintf_chk(char*, long unsigned int, int, long unsigned int, const char*, ...) will always overflow destination buffer [enabled by default]

Something which "will always overflow destnation buffer" seems to qualify to cherry pick to FF33?

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/645d232705b3