1057188 - L10n follow-up for mount/unmount SD card

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Théo Chevalier]

We should replace "..." with "…" in https://gaia-l10n.paas.allizom.org/integration/gaia-central/rev/ec56dfd93d32#l4.16

No need to change the entity, typography fixing only.

Comment 1

[Théo Chevalier]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23170

Comment 2

[Théo Chevalier]

Also, removing the space before ":"

Comment 3

[Théo Chevalier]

>total-size=Total size : {{size}}

Didn't see it in the UI yet, but at first glance it's wrong, we need {{size}} {{unit}}

Like for the string in system:
sdcard-total-size-body=Total size: {{size}} {{unit}}

This would require a new entity name, this time.

Comment 4

[Théo Chevalier]

Comment on attachment 8477166 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/23170

Canceling for now as it might require more work

Comment 5

[Théo Chevalier]

"total-size" doesn't look to be used anywhere…

Comment 6

[Théo Chevalier]

sdcard-removed-eject-successfully=Eject successfully
sdcard-removed-not-eject-properly=Not eject properly

Neo, I don't see those strings in the UX spec. Is it correct in English?

Comment 7

[Théo Chevalier]

And "sdcard-detected=SD Card detected" doesn't seem to be used in Settings.

Comment 8

[Théo Chevalier]

Sorry for the noise, I have another comment.

>sdcard-unknown-size-tap-to-format-body=Unknown, tap to format

This string doesn't make much sense to me, wasn't it supposed to be: "Unknown size, tap to format"?

Comment 9

[Francesco Lodolo [:flod]]

I have a couple more

> total-size=Total size : {{size}}
Space before column seems wrong.

> unmount-sdcard-message=You will not be able to access the content stored on SD card in certain apps after unmount it. Do you want to proceed?
> sdcardUnmounted=SD card unmounted
You just went full jargon: I assume this message is displayed when I eject an SD card. While "eject" is a concept familiar to most of people, unmount is just a technical concept for Linux users.

> sdcard-removed-title=SD card removed
Removed, unmounted or ejected? Unless there are 3 separate concepts/actions.

Comment 10

[Théo Chevalier]

De-assigning myself until the situation get clarified.

Comment 11

[Francesco Lodolo [:flod]]

(In reply to Théo Chevalier [:tchevalier] from comment #5)
> "total-size" doesn't look to be used anywhere…

To be honest I can't find 'sdcard-detected' used either from settings.properties
I'd assume these 2 strings should not be used since the alert is displayed from system

Comment 12

[Matej Novak [:matej]]

Is there a specific string (or strings) I should be looking at here? Could someone put them into a bug comment? Thanks.

Comment 13

[Francesco Lodolo [:flod]]

All the strings landed are here (in green)
https://gaia-l10n.paas.allizom.org/integration/gaia-central/rev/ec56dfd93d32

These two look just wrong (Eject vs Ejected)
> sdcard-removed-eject-successfully=Eject successfully
> sdcard-removed-not-eject-properly=Not eject properly

In these I don't think that "unmount" is the right verb to use (sounds too technical)
> unmount-sdcard-message=You will not be able to access the content stored on SD card in certain apps after unmount it. Do you want to proceed?
> sdcardUnmounted=SD card unmounted

I also believe that we're using a mix of remove/eject/unmount to talk about the same feature.

Comment 14

[Matej Novak [:matej]]

(In reply to Francesco Lodolo [:flod] from comment #13)
> All the strings landed are here (in green)
> https://gaia-l10n.paas.allizom.org/integration/gaia-central/rev/ec56dfd93d32
> 
> These two look just wrong (Eject vs Ejected)
> > sdcard-removed-eject-successfully=Eject successfully
> > sdcard-removed-not-eject-properly=Not eject properly

Agreed. Here are my edits:

+change-default-location-confirmation=Changing the default media storage location will affect where photos, videos, downloads and other media will be saved by default. Existing data will remain in its current location. Do you want to proceed?

+unmount-sdcard-message=You will not be able to access the content stored on the SD card in certain apps after you unmount it. Do you want to proceed?

+sdcard-removed-eject-successfully=Ejected successfully

+sdcard-removed-not-eject-properly=Not ejected properly


> In these I don't think that "unmount" is the right verb to use (sounds too
> technical)
> > unmount-sdcard-message=You will not be able to access the content stored on SD card in certain apps after unmount it. Do you want to proceed?
> > sdcardUnmounted=SD card unmounted
> 
> I also believe that we're using a mix of remove/eject/unmount to talk about
> the same feature.

I didn't change this in the above strings, but I agree that we should be consistent. My only question is whether each one refers to the same action or not.

If so, I would recommend using "remove" throughout.

Stephany, can you add this to your list of things to review?

Thanks.

Comment 15

[Stephany Wilkes]

Thanks Matej!

I'm wondering if we can shorten the rather lengthy media message from "where photos, videos, downloads and other media" to "where all media" or "where photos and all media"?

I'm also trying to think of a way to better communicate user consequence in "You will not be able to access the content stored on the SD card in certain apps after you unmount it. Do you want to proceed?" I'm not sure how much it helps the user to know "in certain apps" without knowing which apps those are, for instance. Perhaps we can say "You will not be able to access content on the SD card after you unmount it" which makes the point pretty clearly. Thoughts?

Comment 16

[Matej Novak [:matej]]

(In reply to Stephany Wilkes from comment #15)
> Thanks Matej!
> 
> I'm wondering if we can shorten the rather lengthy media message from "where
> photos, videos, downloads and other media" to "where all media" or "where
> photos and all media"?
> 
> I'm also trying to think of a way to better communicate user consequence in
> "You will not be able to access the content stored on the SD card in certain
> apps after you unmount it. Do you want to proceed?" I'm not sure how much it
> helps the user to know "in certain apps" without knowing which apps those
> are, for instance. Perhaps we can say "You will not be able to access
> content on the SD card after you unmount it" which makes the point pretty
> clearly. Thoughts?

+1 to both of those, at least from my POV.

Comment 17

[[e-mail], [e-mail]]

(In reply to Théo Chevalier [:tchevalier] from comment #6)
> sdcard-removed-eject-successfully=Eject successfully
> sdcard-removed-not-eject-properly=Not eject properly
> 
> Neo, I don't see those strings in the UX spec. Is it correct in English?

Please reference the UX spec. from [2.1 Settings] MTP_SD card v1.3.pdf(https://bugzilla.mozilla.org/show_bug.cgi?id=922927#c16). I implement the user story according to definition here.

Comment 18

[Axel Hecht [:Pike]]

It's on page 14, but that doesn't change that the strings aren't proper English.

Let's follow Matej's and Stephanie's input here, and fix the spec afterwards.

Comment 19

[Théo Chevalier]

[Blocking Requested - why for this release]:

We have bad quality English strings in product, we need to fix them on 2.1 before string freeze on 09/12/14.

Feel free to take this bug, I'm not sure I'll have enough spare time to fix it in the next days.

Comment 20

[howie [:howie]]

Triage: blocking as bad quality English.

Comment 21

[[e-mail], [e-mail]]

Attachment: pull request 23887

Hi Matej and Théo, 

Could you please help to review the patch according to above refinement and input. I don't make the verb remove/eject/unmount to be consistent because no clearly conclusion for the verb. If we want to make it consistent, we have to change all of the wording on button/notification-message/dialog. Feel free to correct me if I miss something in the patch. Thanks.

Comment 22

[Francesco Lodolo [:flod]]

Left some comments on the PR.

Unfortunately at this point you need new string IDs for most of them, that also means you need to change code and get the PR reviewed by a module owner/peer.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Changing_existing_strings

Comment 23

[[e-mail], [e-mail]]

Comment on attachment 8487007 [details] [review]
pull request 23887

Francesco, thanks for your review quickly. Should I keep review request from Matej and Théo?

Arthur, could you please review the patch for some string ID changed? Thanks.

Comment 24

[[e-mail], [e-mail]]

(In reply to Ian Liu [:ianliu] from comment #23)
> Comment on attachment 8487007 [details] [review]
> pull request 23887
> 
> Francesco, thanks for your review quickly. Should I keep review request from
> Matej and Théo?
> 
Already updated the patch for needed new string ID.

Comment 25

[Francesco Lodolo [:flod]]

Strings look good to me now, no need to ask Théo for review.

There were some doubts about unmount, but at this point is important to land this as soon as possible (before 2.1 is string frozen, which is next Friday).

Comment 26

[[e-mail], [e-mail]]

Comment on attachment 8487007 [details] [review]
pull request 23887

Per comment 25, clear up the review request.

Comment 27

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8487007 [details] [review]
pull request 23887

LGTM, thanks!

Comment 28

[[e-mail], [e-mail]]

Updated patch to change the default string to the new one. Let's wait try-server pass for test.

Comment 29

[Théo Chevalier]

All green, thanks :) https://tbpl.mozilla.org/?rev=957dbbbc359c432c6457666215a4fe23ec18b474&tree=Gaia-Try

Setting checking-needed as it must have landed on 2.1 tomorrow and we need to land on master first.

Comment 30

[[e-mail], [e-mail]]

Gaia/master:  6a533b800e1fa794013887761e62dd4f4d34cea1

Comment 31

[[e-mail], [e-mail]]

Comment on attachment 8487007 [details] [review]
pull request 23887

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1057188
[User impact] if declined: Incorrect string in English.
[Testing completed]: Try-server test passed.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: 5 new strings added, 1 punctuation revised.

Comment 32

[Ryan VanderMeulen [:RyanVM]]

This doesn't have approval to land yet. We have queries that'll find this when it does :)

Comment 33

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/7fe8807b384e1867fa4322f49a1310126fc5a849

Comment 34

[Yeojin Chung [:YeojinC]]

I was able to verify the following strings on Flame 2.2 and 2.1:

- "You will not be able to access content on the SD card after you unmount it. Do you want to proceed?"

- "Changing the default media storage location will affect where all media will be saved by default. Existing data will remain in its current location. Do you want to proceed?"

- "Formatting…"

- "When I selected "Eject SD card", "SD card unmounted" banner at the bottom appeared."

Can I get exact STRs to verify other strings please? I was unable to get strings such as "Unknown size, tap to format", "Ejected successfully", "Not ejected properly".

Flame 2.2

Device: Flame Master (319mb)(Kitkat Base)(Full Flash)
Build ID: 20141028040202
Gaia: 6a7fb482a03c5083ef79b41e7b0dfab27527cd04
Gecko: a255a234946e
Version: 36.0a1 (Master)
Firmware Version: v188
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0
  
Flame 2.1 

Device: Flame 2.1 (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141028001203
Gaia: a0174f7166745256aaca1cb3aa9f894033fbffa6
Gecko: 43bda3541f6b
Gonk: 6e51d9216901d39d192d9e6dd86a5e15b0641a89
Version: 34.0 (2.1)
Firmware: V188
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 35

[Théo Chevalier]

(In reply to Yeojin Chung [:YeojinC] from comment #34)
> I was able to verify the following strings on Flame 2.2 and 2.1:
> 
> - "You will not be able to access content on the SD card after you unmount
> it. Do you want to proceed?"
> 
> - "Changing the default media storage location will affect where all media
> will be saved by default. Existing data will remain in its current location.
> Do you want to proceed?"
> 
> - "Formatting…"
> 
> - "When I selected "Eject SD card", "SD card unmounted" banner at the bottom
> appeared."
> 
> Can I get exact STRs to verify other strings please? I was unable to get
> strings such as "Unknown size, tap to format", "Ejected successfully", "Not
> ejected properly".
> 

I definitely remember the notifications with at least "Ejected successfully" were working when feature landed, and now it's not working anymore. I'd call that either a regression or spec update.
But from the spec version I can see, notifications should be displayed after the banner> https://bug922927.bugzilla.mozilla.org/attachment.cgi?id=8473426 (page 14)

Comment 36

[KTucker [:KTucker][Inactive 3/4/2016]]

Alison, was this changed in the specs or is this a regression? Please see comment 35

Comment 37

[Delphine Lebédel [:delphine - Use needinfo]]

clearing out the ni. Thanks for helping out Theo!

Comment 38

[Alison Shiue]

Since Flame is not a hot plugging device, it may not detect SD card insert/remove very well. Please test those SD card insert/remove notifications via Helix which supports hot plugging.