Closed Bug 1057330 Opened 5 years ago Closed 5 years ago

add Vertical_Orientation to Unicode character property tables

Categories

(Core :: Internationalization, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(3 files, 1 obsolete file)

This will be needed to support text-orientation:mixed in vertical writing modes.
Blocks: 902762
Blocks: 1057331
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Sorry, uploaded a stale patch the first time.
Attachment #8478942 - Flags: review?(smontagu)
Attachment #8478940 - Attachment is obsolete: true
Attachment #8478940 - Flags: review?(smontagu)
Comment on attachment 8478938 [details] [diff] [review]
pt 1 - update genUnicodePropertyData tool to add Vertical_Orientation property.

Review of attachment 8478938 [details] [diff] [review]:
-----------------------------------------------------------------

::: intl/unicharutil/tools/genUnicodePropertyData.pl
@@ +770,5 @@
> +  unsigned char mEAW:3;
> +  unsigned char mCategory:5;
> +  unsigned char mBidiCategory:5;
> +  unsigned char mXidmod:4;
> +  signed char mNumericValue:5;

Nit: might as well line up mNumericValue with the other names (yes, I admit I'm obsessional/compulsive about this kind of thing)
Attachment #8478938 - Flags: review?(smontagu) → review+
Comment on attachment 8478939 [details] [diff] [review]
pt 2 - regenerate Unicode character property tables with updated tool.

Review of attachment 8478939 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8478939 - Flags: review?(smontagu) → review+
Attachment #8478942 - Flags: review?(smontagu) → review+
You need to log in before you can comment on or make changes to this bug.