1057330 - add Vertical_Orientation to Unicode character property tables

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Jonathan Kew [:jfkthame]]

This will be needed to support text-orientation:mixed in vertical writing modes.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: pt 1 - update genUnicodePropertyData tool to add Vertical_Orientation property.

Comment 2

[Jonathan Kew [:jfkthame]]

Attachment: pt 2 - regenerate Unicode character property tables with updated tool.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: pt 3 - provide character property accessor for Vertical_Orientation

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: pt 3 - provide character property accessor for Vertical_Orientation

Sorry, uploaded a stale patch the first time.

Comment 5

[Simon Montagu :smontagu]

Comment on attachment 8478938 [details] [diff] [review]
pt 1 - update genUnicodePropertyData tool to add Vertical_Orientation property.

Review of attachment 8478938 [details] [diff] [review]:
-----------------------------------------------------------------

::: intl/unicharutil/tools/genUnicodePropertyData.pl
@@ +770,5 @@
> +  unsigned char mEAW:3;
> +  unsigned char mCategory:5;
> +  unsigned char mBidiCategory:5;
> +  unsigned char mXidmod:4;
> +  signed char mNumericValue:5;

Nit: might as well line up mNumericValue with the other names (yes, I admit I'm obsessional/compulsive about this kind of thing)

Comment 6

[Simon Montagu :smontagu]

Comment on attachment 8478939 [details] [diff] [review]
pt 2 - regenerate Unicode character property tables with updated tool.

Review of attachment 8478939 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me

Comment 7

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0eb32e869ee3
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0933bde618b
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f9a9cfeabe7

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0eb32e869ee3
https://hg.mozilla.org/mozilla-central/rev/e0933bde618b
https://hg.mozilla.org/mozilla-central/rev/7f9a9cfeabe7