1057402 - Log the message type when we get a message error

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Test code

Testing with this produces:

158 INFO ###!!! [Parent][DispatchAsyncMessage] Error: (msgtype=5898241,name=???) R
oute error: message sent to unknown actor ID
159 INFO ###!!! [Parent][MessageChannel] Error: Channel error: cannot send/recv

And from msgtype we can back out the protocol and message.

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8477442 [details] [diff] [review]
Patch

Review of attachment 8477442 [details] [diff] [review]:
-----------------------------------------------------------------

::: ipc/glue/MessageChannel.cpp
@@ +1578,5 @@
>          NS_RUNTIMEABORT("unknown Result code");
>          return false;
>      }
>  
> +    char printedMsg[256];

How about 512? Some of these protocol/message names can be long

@@ +1579,5 @@
>          return false;
>      }
>  
> +    char printedMsg[256];
> +    PR_snprintf(printedMsg, 256, "(msgtype=%d,name=%s) %s",

How about this:

  PR_snprintf(printedMsg, sizeof(printedMsg),
              "(msgtype=0x%lx, name='%s') %s",
              aMsg.type(), aMsg.name(), errorMsg);

Important bits are that you don't want to hardcode size twice, and msg.type() returns a 32bit number.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/b2g-inbound/rev/1324c90058c2

Comment 4

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/301f3d899f83

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Fixes for build bustage:

https://hg.mozilla.org/integration/b2g-inbound/rev/c75ac37ffe0d
 https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/d946233724d5

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1324c90058c2
https://hg.mozilla.org/mozilla-central/rev/c75ac37ffe0d