105742 - focus ring not visible for linked images or button images with non-transparent backgrounds

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[sairuh (rarely reading bugmail)]

marc, i couldn't find a recent bug you filed on this...but feel free to dup if
the bug does exist!

while doing some tabbing navigation tests, i noticed that sometimes the focus
ring for image links is invisible. this seems to occur when the image doesn't
have a transparent background.

some examples --just tab to a given linked image [look at the status bar to make
sure you have the correct link/focused item]:

* focus ring present: http://hopey.mcom.com/tests/image-link.html --the image
link has a transparent background.

* focus ring absent: http://hopey.mcom.com/tests/image-link2.html --the image
link has an opaque [white] background. the focus ring remains absent even though
the web page background color isn't the same as the image's.

* focus ring absent: http://bugzilla.mozilla.org/ --don't see the the focus ring
for the banner.

what needs to be done is to somehow display an outline that's the inverse of the
image's broder color...

Comment 1

[sairuh (rarely reading bugmail)]

was wondering whether form buttons using images would also be affected. after
checking Viewer test #8: Forms, it looks like button images also don't show the
focus ring.

Comment 2

[al duffy]

I'm not sure this is related or not. But I have seen instances of focus rings
around "IMG"'s but the focus ring does not completely enclose the image. The
length of the rectangle seems big enough, but the width is only a few pixels or
so. For example.

1) Go to www.msn.com

2) Use the mouse to select any topic from "Today on msn"

3) When the page for the selected subject loads, there is a logo for "msn" near
the upper left hand corner. (It's the letters "msn" with a colored butterfly
trademark and is a link to "go.msn.com/...")
4) Use the TAB key to try and shift the focus ring to the image. Sometimes the
focus ring appears as a long thin rectangle positioned at the top of the image.
 Sometimes the focus ring appears as a long thin rectangle positioned at the
bottom of the image. Sometimes no focus ring appears. It's unpredictable.

5) Repeat steps 1-4 by selecting different topics from different categories on
the main "msn.com" page and you'll see how the focus ring location varies when
positioned on the MSN logo. 

Comment 3

[rubydoo123]

using the win32 build from 20011218 on win98, I do not see the focus rings on 
any of the test cases given

Comment 4

[Aaron Leventhal]

Plussing per ADT 

Comment 5

[Marc Attinasi]

Yes, the focus ring si the height of the line-box, not the height of the image.
 A known problem for many years...  accepting and investigating (P3 since it is
not a crash)

Comment 6

[karnaze (gone)]

Taking the bug. 

Comment 7

[karnaze (gone)]

Attachment: patch to fix the bug

Comment 8

[Marc Attinasi]

Comment on attachment 73302 [details] [diff] [review]
patch to fix the bug

sr=attinasi, but you should expand your rule to include <object> (and maybe
<embed>)

Comment 9

[karnaze (gone)]

Attachment: revised patch

Comment 10

[Alexandru Savulov]

Comment on attachment 73312 [details] [diff] [review]
revised patch 

r=alexsavulov

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 73312 [details] [diff] [review]
revised patch 

a=roc+moz

Comment 12

[karnaze (gone)]

The patch is in.

Comment 13

[Chris Petersen]

Marking verified in the Windows ME trunk (2002-04-17-11) and OS X trunk
(2002-04-17-03) 

Comment 14

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381