1057420 - Bug suggestions: Use crash the signature as an additional search term even if the test name returned results

Status: NEW

(Tree Management :: Treeherder, defect, P3)

Description

[Ed Morley [:emorley]]

In TBPL:
1) Try to extract a test name/search term
2) Search for bugs using that search term, but limited to bugs changed in the last 3 months.
3) If no bug results, try extracting a crash signature and searching for that.

Currently in Treeherder:
1) Try to extract a test name/search term
2) Search for bugs using that search term, not limited by age.
3) If no bug results, try extracting a crash signature and searching for that.

The difference between step #2 for each, means that we reach #3 less often in Treeherder compared to TBPL.

To solve this simply (and also solve a TBPL feature request as an added bonus), we should just always search for crash signature and show results from that in addition to the standard search term, and not just as a fall-back.

Comment 1

[Ed Morley [:emorley]]

My initial thought was that we could just combine the results from two separate get_bugs_for_search_term() calls, however that seems a bit suboptimal, with needing to join the two dicts and also handle duplicate bugs.

I think the better fix to this is to just modify get_bugs_for_search_term() such that it accepts multiple search terms - and then returns the joined list of bugs that match any of those. Or alternatively, make it accept search_term and crash_signature, with the latter being optional (given that a crash signature may not be present).

Comment 2

[Ed Morley [:emorley]]

It's hard to say how many cases fall into this category. If it's a lot, this would need to be made a blocker. However given not sure & given not as trivial a fix as say bug 1059788, let's leave this a non-blocker for now.

Comment 3

[Ed Morley [:emorley]]

Morphing this to not just be about the change in behaviour from TBPL, but the more general "make us search against both test name and crash signature all the time, rather than only using crash signature as a fallback".

Comment 4

[Ed Morley [:emorley]]

Context:

14:32 <bkelly> emorley: except bug 1135068 was written back in february
14:35 <emorley> bkelly: the summary isn't currently sufficient to match against that failure (https://github.com/mozilla/treeherder/blob/master/treeherder/log_parser/utils.py#L184-L214)
14:42 <emorley> bkelly: I've tweaked bug 1057420 slightly, so it would now help with this case (which is: another bug matching the test name, so we never use the crash signature fallback)