1057447 - Bug suggestions: Crash signature search passes the wrong variable to get_bugs_for_search_term()

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P1)

Description

[Ed Morley [:emorley]]

https://github.com/mozilla/treeherder-service/blob/master/treeherder/log_parser/tasks.py#L93

    # no suggestions, try to use
    # the crash signature as search term
    crash_signature = get_crash_signature(clean_line)
    if crash_signature:
        if not crash_signature in terms_requested:
            bugs = get_bugs_for_search_term(
                search_term,
                bugscache_uri
            )
            terms_requested[crash_signature] = bugs
        else:
            bugs = terms_requested[crash_signature]

The get_bugs_for_search_term() call should use crash_signature not search_term.

Comment 1

[Ed Morley [:emorley]]

Attachment: Use correct search term

Comment 2

[Ed Morley [:emorley]]

Tests pass locally.

Comment 3

[Ed Morley [:emorley]]

Thanks :-)

https://github.com/mozilla/treeherder-service/commit/36e9bf64ce4bde22a4bb57fbf754ddaae5d635a0