Bug suggestions: Crash signature search passes the wrong variable to get_bugs_for_search_term()

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
https://github.com/mozilla/treeherder-service/blob/master/treeherder/log_parser/tasks.py#L93

    # no suggestions, try to use
    # the crash signature as search term
    crash_signature = get_crash_signature(clean_line)
    if crash_signature:
        if not crash_signature in terms_requested:
            bugs = get_bugs_for_search_term(
                search_term,
                bugscache_uri
            )
            terms_requested[crash_signature] = bugs
        else:
            bugs = terms_requested[crash_signature]

The get_bugs_for_search_term() call should use crash_signature not search_term.
(Assignee)

Updated

4 years ago
Assignee: nobody → emorley
Status: NEW → ASSIGNED
(Assignee)

Comment 1

4 years ago
Created attachment 8478950 [details] [diff] [review]
Use correct search term
Attachment #8478950 - Flags: review?(mdoglio)
(Assignee)

Comment 2

4 years ago
Tests pass locally.
Attachment #8478950 - Flags: review?(mdoglio) → review+
(Assignee)

Comment 3

4 years ago
Thanks :-)

https://github.com/mozilla/treeherder-service/commit/36e9bf64ce4bde22a4bb57fbf754ddaae5d635a0
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.