Closed
Bug 1057447
Opened 9 years ago
Closed 9 years ago
Bug suggestions: Crash signature search passes the wrong variable to get_bugs_for_search_term()
Categories
(Tree Management :: Treeherder, defect, P1)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
1.35 KB,
patch
|
mdoglio
:
review+
|
Details | Diff | Splinter Review |
https://github.com/mozilla/treeherder-service/blob/master/treeherder/log_parser/tasks.py#L93 # no suggestions, try to use # the crash signature as search term crash_signature = get_crash_signature(clean_line) if crash_signature: if not crash_signature in terms_requested: bugs = get_bugs_for_search_term( search_term, bugscache_uri ) terms_requested[crash_signature] = bugs else: bugs = terms_requested[crash_signature] The get_bugs_for_search_term() call should use crash_signature not search_term.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8478950 -
Flags: review?(mdoglio)
Assignee | ||
Comment 2•9 years ago
|
||
Tests pass locally.
Updated•9 years ago
|
Attachment #8478950 -
Flags: review?(mdoglio) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Thanks :-) https://github.com/mozilla/treeherder-service/commit/36e9bf64ce4bde22a4bb57fbf754ddaae5d635a0
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•