1057466 - ProfileUnlockerWin should be robust against target process that terminates during unlock attempt

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

We need to ensure that ProfileUnlockerWin::Unlock is robust if the target process happens to terminate concurrently while it is running. Returning an error code might be bad in some cases for UX reasons.

For example, a user could opt to terminate the "hung" Firefox process, the hung process finally quits, our terminate attempt fails and returns an error code, and then the user has to launch Firefox yet again.

We should return success in cases where we've detected that the process has terminated itself.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Take care of cases where our profile unlock races with the target process terminating itself

This patch essentially adds checks at each point where the unlocker might fail if the target process ends up terminating itself and returns NS_OK if the process is now gone.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/595c082491e8

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/595c082491e8