1057579 - [Loop]Video calls are still made with Audio set as the default call mode

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect, P1)

Description

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Attachment: Starts a video call logcat

Description:
When the user selects Audio as their default call mode, the phone will still send a video feed by default.


Repro Steps:
1) Update a Flame to 20140822030000
2) Create a contact with an email address
3) Install Loop on the device and sign in
4) Change the default call mode to Audio
5) Call the contact created in step 2


Actual:
The call is started as a video call.


Expected:
The call is started as an audio call.

Environmental Variables:
Device: Flame 2.0 (319 MB)
Build ID: 20140822030000
Gaia: 06edd086387c2150017b549e6318a61cd7e4fd02
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0)
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Loop Version: 2a10cd6

Repro frequency: 100%
See attached: video, logcat

Comment 1

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue does occur on Flame 2.1, Flame 2.0 on v123, Flame 2.0 on v165 KK (512 MB), and OpenC 2.0
The call will always default to Video mode.

Environmental Variables:
Device: Flame Master
BuildID: 20140822040202
Gaia: afcdd36f13e75adcdebe57d842a277fd587faf28
Gecko: 0b9dd32d1e16
Version: 34.0a1 (Master) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.0
BuildID: 20140822000206
Gaia: 64b0c0ae60fdeac953a7e2a3c368d124bf848477
Gecko: 5075528d7241
Version: 32.0 (2.0) 
Firmware Version: v123
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Flame 2.0 (512 MB)
BuildID: 20140822030000
Gaia: 06edd086387c2150017b549e6318a61cd7e4fd02
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Environmental Variables:
Device: Open_C 2.0
BuildID: 20140822000206
Gaia: 64b0c0ae60fdeac953a7e2a3c368d124bf848477
Gecko: 5075528d7241
Version: 32.0 (2.0) 
Firmware Version: P821A10V1.0.0B06_LOG_DL
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Loop Version: 2a10cd6

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

The 2.0 Flame on the v123 base in comment 1 is on 319 MB.

Comment 3

[KTucker [:KTucker][Inactive 3/4/2016]]

Massimo, can you weigh in on this issue please? Seems like a potential blocker.

Comment 4

[Maria Angeles Oteo (:oteo)]

Jaime, can you clarify step 5 in the STR?
How have you called that contact? 

There are three options to start a Direct Loop Mobile Call:
1)Tapping on a Call Log entry in the Call Log of the Loop Mobile Application (in this case the new should be of the same type of the call log entry - i.e. the default call mode is not taken into account)
2)Picking a contact in the Contact List inside Loop Mobile Application (in this case the default call mode in Loop settings is used)
3)Entering in the Contact application and tapping on the specific Loop buttons (audio or video buttons) in the contact details screen (the default mode is not taken into account)

Comment 5

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Maria
The steps were written up with case 1 in mind, but the same occurs if step 2 with an audio conversation.  The result is that a video call is always started.

Comment 6

[Maria Angeles Oteo (:oteo)]

(In reply to Jayme Mercado [:JMercado] from comment #5)
> Maria
> The steps were written up with case 1 in mind, but the same occurs if step 2
> with an audio conversation.  The result is that a video call is always
> started.

Thanks! For the sake of clarity:

- In case 1, the default call mode must be ignored. 
  A/ If you click on a video call log entry, a video call must be always started.
  B/ If you click on an audio call log entry, an audio call must be always started.

- In case 2, the default call mode must be always used:
  C/ If the default call mode is video, a video call must be always started.
  D/ If the default call mode is audio, an audio call must be always started.

Which of these 4 scenarios (A,B,C,D) are currently not working as expected? Thanks!

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Maria
Scenarios B and D above do not work as expected.  A video call will start instead of an audio call.

Comment 8

[Maria Angeles Oteo (:oteo)]

Thanks a lot Jayme!
Totally right, I am reproducing them right now, it seems something has been broken because this was working before my holidays.

Blocking bug, Borja, can you have a look at it? Thanks!

Comment 9

[Borja Salguero [:borjasalguero]]

Taking this! I'll try to upload a patch tomorrow :)

Comment 10

[Borja Salguero [:borjasalguero]]

From product perspective, the requirement is that we need to make the call taking into account the status of the previous call, so if an entry was a video-call, tapping on it will be a video-call regardless the 'default-call-mode' setting in Settings. I'll upload a patch following this.

Comment 11

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

With this patch, when tapping on a calllog entry, we will launch the call following the same params related to video/audio.

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8487056 [details] [review]
Pull Request

LGTM. r=me

Thanks for taking care of it Borja!

Comment 13

[Javier de Prado]

Verified on:
Flame: user.v2.0.184based.B-57.Gecko-dde9d61.Gaia-7b8df99
FireE: firee-kk-v2.0-SW2E5-4
Loop 1.1, version: aba155c