1057626 - java.lang.NoSuchMethodError: android.net.ConnectivityManager.isActiveNetworkMetered

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

I ran into this crash on a Nexus S running 2.3.6:

E/AndroidRuntime( 8502): FATAL EXCEPTION: IntentService[updater]
E/AndroidRuntime( 8502): java.lang.NoSuchMethodError: android.net.ConnectivityManager.isActiveNetworkMetered
E/AndroidRuntime( 8502): 	at org.mozilla.gecko.updater.UpdateService.startUpdate(UpdateService.java:221)
E/AndroidRuntime( 8502): 	at org.mozilla.gecko.updater.UpdateService.onHandleIntent(UpdateService.java:125)
E/AndroidRuntime( 8502): 	at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:59)
E/AndroidRuntime( 8502): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime( 8502): 	at android.os.Looper.loop(Looper.java:130)
E/AndroidRuntime( 8502): 	at android.os.HandlerThread.run(HandlerThread.java:60)

It looks like it might be a regression from bug 1052100.

Comment 1

[Aaron Train [:aaronmt]]

isActiveNetworkMetered API 16 (4.1)

Comment 2

[Theodore Kokkoris [:tgkokk]]

Attachment: 1057626-use-cm-compat.patch

Sorry, that was me. I've attached a patch that should fix it.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8477852 [details] [diff] [review]
1057626-use-cm-compat.patch

Review of attachment 8477852 [details] [diff] [review]:
-----------------------------------------------------------------

Need the extraneous changes removed, otherwise looks fine.

::: mobile/android/base/updater/UpdateService.java
@@ +127,2 @@
>              // Use this instead for forcing a download from about:fennec
> +            startUpdate(UpdateServiceHelper.FLAG_REINSTALL);

We don't want these changes

Comment 4

[Theodore Kokkoris [:tgkokk]]

Attachment: Use ConnectivityManagerCompat instead of ConnectivityManager

Sorry, was trying to find out how to test the updater.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Theodore Kokkoris [:tgkokk] from comment #4)
> Created attachment 8478304 [details] [diff] [review]
> Use ConnectivityManagerCompat instead of ConnectivityManager
> 
> Sorry, was trying to find out how to test the updater.

No worries. The code you had there worked for that, right?

Comment 6

[Theodore Kokkoris [:tgkokk]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #5)
> (In reply to Theodore Kokkoris [:tgkokk] from comment #4)
> > Created attachment 8478304 [details] [diff] [review]
> > Use ConnectivityManagerCompat instead of ConnectivityManager
> > 
> > Sorry, was trying to find out how to test the updater.
> 
> No worries. The code you had there worked for that, right?

You mean the one I deleted? Nope, apparently for some reason the update server wouldn't return any updates. I tried it manually with the URL it was returning and I received an empty <updates> element, Nightly branding and all (maybe that was the reason). I'm going to give it one more try later, I'm going to file another bug now (which was ultimately why I decided to test if I can enable the updater).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Can we please run this through Try first? :)

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #7)
> Can we please run this through Try first? :)

There is no point as long as this builds (which I assume it does). There are no updater tests.

Comment 10

[Gian-Carlo Pascutto [:gcp]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/81307805adbb

Comment 11

[:Margaret Leibovic]

We'll need to uplift this to Aurora.

Comment 12

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8478304 [details] [diff] [review]
Use ConnectivityManagerCompat instead of ConnectivityManager

Approval Request Comment
[Feature/regressing bug #]: Bug 1052100
[User impact if declined]: No Aurora updates for all Android devices < Jelly Bean.
[Describe test coverage new/current, TBPL]: None.
[Risks and why]: None really.
[String/UUID change made/needed]: N/A

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/81307805adbb

Comment 14

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8478304 [details] [diff] [review]
Use ConnectivityManagerCompat instead of ConnectivityManager

Aurora+

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/55d92d900511