1057650 - Investigate whether new_tablet_browser_toolbar can be a LinearLayout

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Via bug 1046203 comment 12:

>With the exception of the back/forward buttons, I think the new toolbar layout
>will be a lot more linear with no overlapping children. It we could change the
> new tablet toolbar to be a simpler LinearLayout instead.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is possible, but might take a little work:
  * the translating url_bar_* (phones) intersect with one another, meaning this needs to be contained within a single View's bounds but still allowed to draw outside those bonuds (for expansion)
  * The edit_cancel button is contained within the LinearLayout - we would probably need to swap in and out the "display" layout and "editing" layout, kind of like what we do with ToolbarEditlayout and ToolbarDisplayLayout, but at the view root level.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #1)
>   * the translating url_bar_* (phones) intersect with one another, meaning
> this needs to be contained within a single View's bounds but still allowed
> to draw outside those bonuds (for expansion)

Note that this is only necessary for phones, however, both phone and tablet inherit from the same `BrowserToolbar extends RelativeLayout` class.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

try, parts 0-5: https://tbpl.mozilla.org/?tree=Try&rev=6a22c41e8781

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Ignore comment 3: wrong bug.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.