Closed Bug 1057651 Opened 6 years ago Closed 6 years ago

Remove excess padding from new_tablet_browser_toolbar edit_cancel

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 35

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

(Whiteboard: [fixed-larch])

Attachments

(1 file)

Via bug 1046203 comment 12:

@@ +112,5 @@
> +            style="@style/UrlBar.ImageButton.Icon"
> +            android:layout_alignParentRight="true"
> +            android:src="@drawable/close_edit_mode_selector"
> +            android:paddingLeft="2dp"
> +            android:paddingRight="2dp"

> Not specific to this patch but I wonder if this padding is actually necessary. > Please file a follow-up to remove it from all *browser_toolbar.xml if it's not.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Summary: Investigate whether new_tablet_browser_toolbar padding is necessary → Remove excess padding from new_tablet_browser_toolbar edit_cancel
Attachment #8478598 - Flags: review?(lucasr.at.mozilla) → review+
Whiteboard: [fixed-larch]
https://hg.mozilla.org/mozilla-central/rev/a2761125b25e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 35
You need to log in before you can comment on or make changes to this bug.