1057685 - regression: Tweak Browser:Quit to maintain existing support for add-ons - part deux

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Capella [:capella]]

Simple regression by Bug 1052387 ...

Comment 1

[Mark Capella [:capella]]

Attachment: bug1057685.diff

Comment 2

[Mark Capella [:capella]]

And ping on this?

Comment 3

[Mark Capella [:capella]]

https://hg.mozilla.org/integration/fx-team/rev/6797921c8f49

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6797921c8f49

Comment 5

[Mark Capella [:capella]]

Comment on attachment 8477821 [details] [diff] [review]
bug1057685.diff

Approval Request Comment: I've gotten a couple complaints pointing out that this patch hasn't been promoted to Beta yet, but the bug causing the regression was, so addons like QuitNow, and CleanQuit temporarily don't work.

[Feature/regressing bug #]: Bug 1052387
[User impact if declined]: Add-on unavailable in Beta until next release, unavailable in Release after that.

[Describe test coverage new/current, TBPL]: Local testing, currently baking in m-c, and m-a.
[Risks and why]: S/b low to none.

[String/UUID change made/needed]: none

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8477821 [details] [diff] [review]
bug1057685.diff

Good fix to avoid breaking add-ons in 33. beta+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dbfd31597299

Comment 8

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in
Builds:
Firefox for Android 34 Beta 1
Firefox for Android 33
Device: Asus Transformer Pad TF300T (Android 4.2.1)