regression: Tweak Browser:Quit to maintain existing support for add-ons - part deux

VERIFIED FIXED in Firefox 33

Status

()

Firefox for Android
General
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: capella, Assigned: capella)

Tracking

({regression})

unspecified
Firefox 34
ARM
Android
regression
Points:
---

Firefox Tracking Flags

(firefox32 unaffected, firefox33+ verified, firefox34 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Simple regression by Bug 1052387 ...
(Assignee)

Comment 1

3 years ago
Created attachment 8477821 [details] [diff] [review]
bug1057685.diff
Attachment #8477821 - Flags: review?(wjohnston)
(Assignee)

Updated

3 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 2

3 years ago
And ping on this?
Attachment #8477821 - Flags: review?(wjohnston) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/6797921c8f49
https://hg.mozilla.org/mozilla-central/rev/6797921c8f49
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
(Assignee)

Comment 5

3 years ago
Comment on attachment 8477821 [details] [diff] [review]
bug1057685.diff

Approval Request Comment: I've gotten a couple complaints pointing out that this patch hasn't been promoted to Beta yet, but the bug causing the regression was, so addons like QuitNow, and CleanQuit temporarily don't work.

[Feature/regressing bug #]: Bug 1052387
[User impact if declined]: Add-on unavailable in Beta until next release, unavailable in Release after that.

[Describe test coverage new/current, TBPL]: Local testing, currently baking in m-c, and m-a.
[Risks and why]: S/b low to none.

[String/UUID change made/needed]: none
Attachment #8477821 - Flags: approval-mozilla-beta?
status-firefox32: --- → unaffected
status-firefox33: --- → affected
status-firefox34: --- → fixed
tracking-firefox33: --- → +
Keywords: regression
Comment on attachment 8477821 [details] [diff] [review]
bug1057685.diff

Good fix to avoid breaking add-ons in 33. beta+
Attachment #8477821 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/dbfd31597299
status-firefox33: affected → fixed
Verified as fixed in
Builds:
Firefox for Android 34 Beta 1
Firefox for Android 33
Device: Asus Transformer Pad TF300T (Android 4.2.1)
Status: RESOLVED → VERIFIED
status-firefox33: fixed → verified
status-firefox34: fixed → verified
You need to log in before you can comment on or make changes to this bug.