Closed Bug 1057685 Opened 5 years ago Closed 5 years ago

regression: Tweak Browser:Quit to maintain existing support for add-ons - part deux

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 34
Tracking Status
firefox32 --- unaffected
firefox33 + verified
firefox34 --- verified

People

(Reporter: capella, Assigned: capella)

Details

(Keywords: regression)

Attachments

(1 file)

Simple regression by Bug 1052387 ...
Attached patch bug1057685.diffSplinter Review
Attachment #8477821 - Flags: review?(wjohnston)
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
And ping on this?
Attachment #8477821 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/6797921c8f49
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Comment on attachment 8477821 [details] [diff] [review]
bug1057685.diff

Approval Request Comment: I've gotten a couple complaints pointing out that this patch hasn't been promoted to Beta yet, but the bug causing the regression was, so addons like QuitNow, and CleanQuit temporarily don't work.

[Feature/regressing bug #]: Bug 1052387
[User impact if declined]: Add-on unavailable in Beta until next release, unavailable in Release after that.

[Describe test coverage new/current, TBPL]: Local testing, currently baking in m-c, and m-a.
[Risks and why]: S/b low to none.

[String/UUID change made/needed]: none
Attachment #8477821 - Flags: approval-mozilla-beta?
Comment on attachment 8477821 [details] [diff] [review]
bug1057685.diff

Good fix to avoid breaking add-ons in 33. beta+
Attachment #8477821 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed in
Builds:
Firefox for Android 34 Beta 1
Firefox for Android 33
Device: Asus Transformer Pad TF300T (Android 4.2.1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.