[Settings] Browser Privacy: l10n issues

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: flod, Assigned: flod)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
https://github.com/mozilla-b2g/gaia/commit/3579256554985d6ad49bee4615651a255962f22f

1) data-l10n-id="clearBookmarksAppsData">

We don't have such an ID, we have clearBookmarkAppsData.

2) We need a different string for menu item and header in Settings (see across settings.properties for references). You created the reference in the header, but not added the string inside settings.properties

<h1 data-l10n-id="browserPrivacy-header"> Browser Privacy </h1>

3) The main title "Confirmation" is hard-coded. 
https://github.com/mozilla-b2g/gaia/commit/3579256554985d6ad49bee4615651a255962f22f#diff-43f348489f2f3323b5a6339221ad7998R34

Why are we not enforcing tests with pseudo-locales? They're build at runtime for this very reason, and all of these issues would have been found within seconds.
(Assignee)

Comment 1

4 years ago
Created attachment 8477827 [details]
Search

I was going to file another bug but discovered it comes from the same bug :-\

Search is using data-l10n-id="search"

We have a "search-header", but not a "search" id
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/locales/settings.en-US.properties
(Assignee)

Comment 2

4 years ago
Created attachment 8480529 [details] [review]
Pull request on Github

Fixing since we're approaching FL and string freeze.

* Added new clear-boomarks-data string for the button instead of reusing the existing one from another panel.
* Switched ID from "confirmation" to less generic "confirm-clear-title".
Assignee: nobody → francesco.lodolo
Attachment #8480529 - Flags: review?(arthur.chen)
Comment on attachment 8480529 [details] [review]
Pull request on Github

Pseudo locale should be used. I feel embarrassed by not catching this. :(

The patch looks good to me, thanks!
Attachment #8480529 - Flags: review?(arthur.chen) → review+
(Assignee)

Comment 4

4 years ago
Thanks Arthur, asking for checkin.
Status: NEW → ASSIGNED
Keywords: checkin-needed
master: e43e40ce50c1b6f331f3f00ef6cf954dff6abbc9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.