Closed
Bug 105773
Opened 23 years ago
Closed 23 years ago
Email addresses in cc list should be sorted case insensitively
Categories
(Bugzilla :: User Interface, defect, P5)
Tracking
()
VERIFIED
FIXED
Bugzilla 2.16
People
(Reporter: jonasj, Assigned: bugzilla)
References
()
Details
Attachments
(1 file, 1 obsolete file)
495 bytes,
patch
|
justdave
:
review+
justdave
:
review+
|
Details | Diff | Splinter Review |
Look at bug 11632 - the first five email addresses in the CC: list begins with A, E, P, S and V! This happens because Bugzilla treats the email addresses as case sensitive values when sorting them, and some people seem to like putting capital letters in their email addresses.
Updated•23 years ago
|
Severity: minor → trivial
Priority: -- → P5
Target Milestone: --- → Bugzilla 2.16
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Comment 2•23 years ago
|
||
Add one liner patch to change the sorting in the bug_form multi-select box only. The sorting is normally done by the RelationSet bug_form.pl:133: my @ccList = $ccSet->toArrayOfStrings(); toArrayOfStrings does a normal sort when it creates the array. Since the database doesn't store order, and I don't want to change the way toArrayOfStrings works, the extra line just does the case-insensitive sort for the interface. The change in order should not have an affect on process_bug.cgi Oh, and someone needs to remove the silly comment I left on the line... I can't seem to edit the patch once it's uploaded. Sorry, it's my first time :)
Assignee | ||
Comment 3•23 years ago
|
||
Oh, and someone needs to mark the bug keywords patch, review...
Comment 5•23 years ago
|
||
Comment on attachment 56237 [details] [diff] [review] Proposed simple interface only fix you can safely go ahead and fix toArrayOfStrings... there's nowhere that uses it for anything other than user display, everything internally treats the list as a set rather than an array.
Attachment #56237 -
Flags: review-
Assignee | ||
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
Added new patch to change RelationSet::toArrayOfString instead of at the .cgi level. The old one needs to be marked as obselete... How does one get patch edit rights?
Status: NEW → ASSIGNED
Updated•23 years ago
|
Attachment #56237 -
Attachment is obsolete: true
Comment 8•23 years ago
|
||
Comment on attachment 56350 [details] [diff] [review] Path to RelationSet.pm instead r= justdave cosmetic change, no 2nd review needed
Attachment #56350 -
Flags: review+
Comment 9•23 years ago
|
||
/cvsroot/mozilla/webtools/bugzilla/RelationSet.pm,v <-- RelationSet.pm new revision: 1.7; previous revision: 1.6
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Comment 10•23 years ago
|
||
Adam, there is no such thing as "patch edit" privileges. If you have "edit bugs" privileges (which I notice that you do), then you can edit patch/attachment records. Note however that you cannot edit the content of the attachment itself, only the data relating to that content (content type, description, status, etc.).
Updated•11 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•