105773 - Email addresses in cc list should be sorted case insensitively

Status: VERIFIED FIXED

(Bugzilla :: User Interface, defect, P5)

Description

[Jonas Jørgensen]

Look at bug 11632 - the first five email addresses in the CC: list begins with 
A, E, P, S and V! This happens because Bugzilla treats the email addresses as 
case sensitive values when sorting them, and some people seem to like putting 
capital letters in their email addresses.

Comment 1

[Adam Kennedy]

Attachment: Proposed simple interface only fix

Comment 2

[Adam Kennedy]

Add one liner patch to change the sorting in the bug_form multi-select box only.
The sorting is normally done by the RelationSet

bug_form.pl:133: my @ccList = $ccSet->toArrayOfStrings();

toArrayOfStrings does a normal sort when it creates the array.

Since the database doesn't store order, and I don't want to change the way 
toArrayOfStrings works, the extra line just does the case-insensitive sort for 
the interface.

The change in order should not have an affect on process_bug.cgi

Oh, and someone needs to remove the silly comment I left on the line... I can't 
seem to edit the patch once it's uploaded. Sorry, it's my first time :)

Comment 3

[Adam Kennedy]

Oh, and someone needs to mark the bug keywords patch, review...

Comment 4

[Dave Miller [:justdave]]

-> patch author

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 56237 [details] [diff] [review]
Proposed simple interface only fix

you can safely go ahead and fix toArrayOfStrings...  there's
nowhere that uses it for anything other than user display, 
everything internally treats the list as a set rather than an array.

Comment 6

[Adam Kennedy]

Attachment: Path to RelationSet.pm instead

Comment 7

[Adam Kennedy]

Added new patch to change RelationSet::toArrayOfString instead of at the .cgi 
level. The old one needs to be marked as obselete... 

How does one get patch edit rights?

Comment 8

[Dave Miller [:justdave]]

Comment on attachment 56350 [details] [diff] [review]
Path to RelationSet.pm instead

r= justdave
cosmetic change, no 2nd review needed

Comment 9

[Dave Miller [:justdave]]

/cvsroot/mozilla/webtools/bugzilla/RelationSet.pm,v  <--  RelationSet.pm
new revision: 1.7; previous revision: 1.6

Comment 10

[Myk Melez [:myk] [@mykmelez]]

Adam, there is no such thing as "patch edit" privileges.  If you have "edit
bugs" privileges (which I notice that you do), then you can edit
patch/attachment records.  Note however that you cannot edit the content of the
attachment itself, only the data relating to that content (content type,
description, status, etc.).

Comment 11

[Jonas Jørgensen]

v