Closed
Bug 1057754
Opened 10 years ago
Closed 10 years ago
Remove the bogus Valgrind annotations from mozjemalloc
Categories
(Core :: Memory Allocator, defect)
Core
Memory Allocator
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
9.70 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
mozjemalloc's Valgrind annotations are bogus and, and mozjemalloc should never
be called when Valgrind is running.
|
Assignee | |
Comment 1•10 years ago
|
||
This patch removes the annotations and adds an abort that is triggered if
jemalloc is initialized while running under Valgrind.
Attachment #8477874 -
Flags: review?(mh+mozilla)
|
||
Updated•10 years ago
|
Attachment #8477874 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Immediately after landing it, I realized the above patch has a problem: it assumes that "running Valgrind" means "running Memcheck". But if you're running Cachegrind, for example, it's better to run with jemalloc enabled, because that's the standard configuration. So I removed the abort:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d937c3db92b
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/775a14a8e190
https://hg.mozilla.org/mozilla-central/rev/8d937c3db92b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•