Remove the bogus Valgrind annotations from mozjemalloc

RESOLVED FIXED in mozilla34

Status

()

Core
Memory Allocator
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla34
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
mozjemalloc's Valgrind annotations are bogus and, and mozjemalloc should never
be called when Valgrind is running.
(Assignee)

Comment 1

4 years ago
Created attachment 8477874 [details] [diff] [review]
Remove the bogus Valgrind annotations from mozjemalloc

This patch removes the annotations and adds an abort that is triggered if
jemalloc is initialized while running under Valgrind.
Attachment #8477874 - Flags: review?(mh+mozilla)
Attachment #8477874 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 3

4 years ago
Immediately after landing it, I realized the above patch has a problem: it assumes that "running Valgrind" means "running Memcheck". But if you're running Cachegrind, for example, it's better to run with jemalloc enabled, because that's the standard configuration. So I removed the abort:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d937c3db92b
https://hg.mozilla.org/mozilla-central/rev/775a14a8e190
https://hg.mozilla.org/mozilla-central/rev/8d937c3db92b
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.