Closed Bug 1057754 Opened 5 years ago Closed 5 years ago

Remove the bogus Valgrind annotations from mozjemalloc

Categories

(Core :: Memory Allocator, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

mozjemalloc's Valgrind annotations are bogus and, and mozjemalloc should never
be called when Valgrind is running.
This patch removes the annotations and adds an abort that is triggered if
jemalloc is initialized while running under Valgrind.
Attachment #8477874 - Flags: review?(mh+mozilla)
Attachment #8477874 - Flags: review?(mh+mozilla) → review+
Immediately after landing it, I realized the above patch has a problem: it assumes that "running Valgrind" means "running Memcheck". But if you're running Cachegrind, for example, it's better to run with jemalloc enabled, because that's the standard configuration. So I removed the abort:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d937c3db92b
https://hg.mozilla.org/mozilla-central/rev/775a14a8e190
https://hg.mozilla.org/mozilla-central/rev/8d937c3db92b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in before you can comment on or make changes to this bug.