jit-test/tests/gc/bug-1055034.js will perma-fail when Gecko 34 merges to Aurora

VERIFIED FIXED in Firefox 34

Status

()

--
major
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

Trunk
mozilla34
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox34 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Merge day is Tuesday, 2-Sep, so this is semi-urgent. Presumably just needs an early abort if arr.mapPar isn't supported.

https://tbpl.mozilla.org/php/getParsedLog.php?id=46644860&tree=Try
(Assignee)

Comment 1

4 years ago
Looking at the other jit-tests that use mapPar, I guess we'd just want to do this?

-run(range(0, 1024), function (i) { var a = []; a.length = i; });
+if (getBuildConfiguration().parallelJS)
+  run(range(0, 1024), function (i) { var a = []; a.length = i; });
(Assignee)

Comment 2

4 years ago
Created attachment 8478224 [details] [diff] [review]
only run the test if ParallelJS is supported

Try says this works.
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #8478224 - Flags: review?(terrence)
Comment on attachment 8478224 [details] [diff] [review]
only run the test if ParallelJS is supported

Review of attachment 8478224 [details] [diff] [review]:
-----------------------------------------------------------------

wfm
Attachment #8478224 - Flags: review?(terrence) → review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/mozilla-central/rev/3ef28e381ad6
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
OK that makes no sense was test only.
but makes me think bug 1055034 is the regressor.
(Assignee)

Updated

4 years ago
Status: RESOLVED → VERIFIED
status-firefox34: --- → verified
You need to log in before you can comment on or make changes to this bug.