1057914 - Remove enumeration methods from nsICommandParams

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Nicholas Nethercote [inactive]]

The enumeration methods in nsCommandParams are really dodgy -- they hold raw pointers into the hash table's entry store and assume that the table doesn't get resized. (I hit other problems in this code in bug 1050036; it doesn't seem to be high-quality code.)

I'd like to just remove these methods. Hopefully this is ok. It'll help with bug 1057912.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Remove enumeration methods from nsICommandParams

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Fix the style of nsCommandParams.{h,cpp}

Because I'm tired of my eyes bleeding all over my keyboard every time I look at
this file.

Comment 3

[(no longer active)]

Comment on attachment 8478061 [details] [diff] [review]
(part 2) - Fix the style of nsCommandParams.{h,cpp}

Review of attachment 8478061 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't really review this...

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/01d9658ee977
https://hg.mozilla.org/integration/mozilla-inbound/rev/b91deae84856

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/01d9658ee977
https://hg.mozilla.org/mozilla-central/rev/b91deae84856