[NFC] nfcd should pass AID origin to gecko

RESOLVED FIXED in 2.1 S3 (29aug)

Status

Firefox OS
NFC
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dimi, Assigned: dimi)

Tracking

unspecified
2.1 S3 (29aug)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [p=1])

Attachments

(1 attachment, 5 obsolete attachments)

(Assignee)

Description

4 years ago
Right now nfcd do not have a proper solution to notify correct AID origin (bug 1043276) to gecko.
But we will still need this for EVT_TRANSACTION. For now, the only possible AID origin is from SIM1, so hard code SIM1 until we find a way to detect AID origin in nfcd
(Assignee)

Comment 1

4 years ago
Created attachment 8478111 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v1
Attachment #8478111 - Flags: review?(allstars.chh)
(Assignee)

Comment 2

4 years ago
Created attachment 8478141 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v2
Attachment #8478111 - Attachment is obsolete: true
Attachment #8478111 - Flags: review?(allstars.chh)
Attachment #8478141 - Flags: review?(allstars.chh)
Comment on attachment 8478141 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v2

See comments on github.
Attachment #8478141 - Flags: review?(allstars.chh)
(Assignee)

Comment 4

4 years ago
Created attachment 8478148 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v3
Attachment #8478141 - Attachment is obsolete: true
Attachment #8478148 - Flags: review?(allstars.chh)
(Assignee)

Comment 5

4 years ago
Created attachment 8478166 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v4

Modification:
- Move convertOriginType from TransactionEvent to NfcUtil
Attachment #8478148 - Attachment is obsolete: true
Attachment #8478148 - Flags: review?(allstars.chh)
Attachment #8478166 - Flags: review?(allstars.chh)
Attachment #8478166 - Flags: review?(allstars.chh) → review+
https://github.com/mozilla-b2g/platform_system_nfcd/commit/b870f24b39b93b8d19d07af94e4d782a2c67518c
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Revert in https://github.com/mozilla-b2g/platform_system_nfcd/pull/55
I'd land this when Bug 979767 landed, otherwise some Warning message (version mismatch) will be shown in logcat.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

4 years ago
Created attachment 8479748 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v5

- Remove Unknown for hci event origin
Attachment #8478166 - Attachment is obsolete: true
Attachment #8479748 - Flags: review?(allstars.chh)
Attachment #8479748 - Flags: review?(allstars.chh) → review+
(Assignee)

Comment 9

4 years ago
Created attachment 8480299 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v6
Attachment #8479748 - Attachment is obsolete: true
Attachment #8480299 - Flags: review+
https://github.com/mozilla-b2g/platform_system_nfcd/commit/eb24caca12c1ee69a26b778f67b802a812550703
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.