Closed Bug 1057960 Opened 10 years ago Closed 10 years ago

[NFC] nfcd should pass AID origin to gecko

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.1 S3 (29aug)

People

(Reporter: dlee, Assigned: dlee)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file, 5 obsolete files)

pull request to mozilla-b2g/platform_system_nfcd v6
59 bytes, text/x-github-pull-request
dlee
: review+
Details | Review 
Right now nfcd do not have a proper solution to notify correct AID origin (bug 1043276) to gecko.
But we will still need this for EVT_TRANSACTION. For now, the only possible AID origin is from SIM1, so hard code SIM1 until we find a way to detect AID origin in nfcd

        Attachment #8478111 -
        Flags: review?(allstars.chh)

    
    

    
  


  

        Attachment #8478111 -
        Attachment is obsolete: true

        Attachment #8478111 -
        Flags: review?(allstars.chh)

        Attachment #8478141 -
        Flags: review?(allstars.chh)

    
    

    
  
Comment on attachment 8478141 [details] [review]
pull request to mozilla-b2g/platform_system_nfcd v2

See comments on github.

        Attachment #8478141 -
        Flags: review?(allstars.chh)

    
    

    
  


  

        Attachment #8478141 -
        Attachment is obsolete: true

        Attachment #8478148 -
        Flags: review?(allstars.chh)

    
    

    
  


  
Modification:
- Move convertOriginType from TransactionEvent to NfcUtil

        Attachment #8478148 -
        Attachment is obsolete: true

        Attachment #8478148 -
        Flags: review?(allstars.chh)

        Attachment #8478166 -
        Flags: review?(allstars.chh)

        Attachment #8478166 -
        Flags: review?(allstars.chh) → review+

    
    

    
  
Revert in https://github.com/mozilla-b2g/platform_system_nfcd/pull/55
I'd land this when Bug 979767 landed, otherwise some Warning message (version mismatch) will be shown in logcat.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  


  
- Remove Unknown for hci event origin

        Attachment #8478166 -
        Attachment is obsolete: true

        Attachment #8479748 -
        Flags: review?(allstars.chh)

        Attachment #8479748 -
        Flags: review?(allstars.chh) → review+

    
    

    
  


  

        Attachment #8479748 -
        Attachment is obsolete: true

        Attachment #8480299 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: