Closed
Bug 1057978
Opened 11 years ago
Closed 11 years ago
MediaDecoderStateMachine::Seek() should do nothing while shutting down
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: jwwang, Assigned: jwwang)
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
It is possible that MediaDecoderStateMachine::Seek() happens on the main thread while MediaDecoderStateMachine::DecodeError() is happening on the decoding thread. If DecodeError() runs first, Seek() will change mState from DECODER_STATE_SHUTDOWN to DECODER_STATE_SEEKING which is a terrible error.
|
Assignee | |
Comment 1•11 years ago
|
||
Handle shutdown in MediaDecoderStateMachine::Seek() which should not change |mState| from DECODER_STATE_SHUTDOWN to DECODER_STATE_SEEKING.
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8478135 [details] [diff] [review]
1057978_fix_MediaDecoderStateMachine_Seek_while_shutdown-v1.patch
Review of attachment 8478135 [details] [diff] [review]:
-----------------------------------------------------------------
Yes!
Attachment #8478135 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
This is a simple change. I will save the Try.
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•