Closed
Bug 1058033
Opened 9 years ago
Closed 9 years ago
e10s `window is null` error in gcli/commands/paintflashing.js on toolbox open
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(1 file)
1.48 KB,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
Run any test with e10s, for instance: mach mochitest-devtools --e10s browser/devtools/framework/test/browser_toolbox_highlight.js There is an error that happens during a promise from toolbox.open, which is triggering some issues such as those seen in Comment 11 and 12 from Bug 1042253. 13 INFO console.error: 14 INFO Message: TypeError: window is null 15 INFO Stack: 16 INFO exports.items<.state.isChecked@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/commands/paintflashing.js:106:15 17 INFO CommandUtils.createButtons/</</onChange@resource:///modules/devtools/DeveloperToolbar.jsm:156:27 18 INFO CommandUtils.createButtons/</<@resource:///modules/devtools/DeveloperToolbar.jsm:167:1 19 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 20 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 21 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9 22 INFO CommandUtils.createButtons/<@resource:///modules/devtools/DeveloperToolbar.jsm:99:14 23 INFO exports.promiseEach/</callNext@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/util.js:277:19 24 INFO exports.promiseEach/</callNext/onSuccess@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/util.js:269:11 25 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 26 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 27 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 28 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9 29 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:58:9 30 INFO exports.promiseEach/</callNext@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/util.js:278:7 31 INFO exports.promiseEach/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/util.js:281:5 32 INFO Promise@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/promise.js:48:5 33 INFO exports.promiseEach@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/gcli/util/util.js:258:1 34 INFO CommandUtils.createButtons@resource:///modules/devtools/DeveloperToolbar.jsm:97:1 35 INFO Toolbox.prototype._buildButtons/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/framework/toolbox.js:601:14 36 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 37 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 38 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 39 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 40 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 41 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 42 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 43 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 44 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 45 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 46 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 47 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:40 48 INFO then@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:20:43 49 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:72:11 50 INFO resolve@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js:40:11 51 INFO Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:865:23 52 INFO this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:744:7
Assignee | ||
Comment 1•9 years ago
|
||
Note that this doesn't actually fix paintflashing in e10s, rather simply prevents any errors from firing during creation. https://tbpl.mozilla.org/?tree=Try&rev=bb81b6a40c3e
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Attachment #8479324 -
Flags: review?(fayearthur)
Assignee | ||
Comment 2•9 years ago
|
||
With this patch applied plus the WIP in Bug 1042253, browser/devtools/webconsole/test/browser_webconsole_split_persist.js seems to pass again
Updated•9 years ago
|
Attachment #8479324 -
Flags: review?(fayearthur) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/76cce82c1116
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/76cce82c1116
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Flags: qe-verify-
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•