Closed Bug 1058115 Opened 5 years ago Closed 4 years ago

[flatfish] Re-size/position favicon on homescreen based on MAX_ICON_SIZE

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: bobchao, Assigned: bobchao, Mentored)

References

Details

(Whiteboard: [flatfish])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140823030201

Steps to reproduce:

Bug 1042730 helps people use a larger icon when add sites to homescreen if available.  However, with large screen & for sites that don't have a larger icon, we could (at least) re-size / center the favicon for a better result.

Check 4 labeled icons in the screenshot attached:

(1) Pretty, HD icon with help from bug 1042730
(2) For a site that don't have larger icon, the icon was placed at top-left of the circle.
(3) Icon comes from packaged app.

I tried to modify page.js in apps/homescreen/js and create the icon (4), the favicon part was re-sized/positioned based on MAX_ICON_SIZE, which is 60 for tiny screen and 90 for large screen.

ctx.drawImage(img, (0.25 * MAX_ICON_SIZE + ICON_PADDING_IN_CANVAS / 2 ) * SCALE_RATIO, (0.25 * MAX_ICON_SIZE + ICON_PADDING_IN_CANVAS / 2 ) * SCALE_RATIO, 0.5 * MAX_ICON_SIZE * SCALE_RATIO, 0.5 * MAX_ICON_SIZE * SCALE_RATIO);

Not sure if this is an acceptable solution, any suggestion?
Whiteboard: [flatfish]
Assignee: nobody → bobchao
Whiteboard: [flatfish] → [flatfish][[mentor=sherman]
Mentor: shchen
Status: UNCONFIRMED → NEW
Ever confirmed: true
Whiteboard: [flatfish][[mentor=sherman] → [flatfish]
Mass update: Resolve wontfix all issues with legacy homescreens.

As of 2.6 we have a new homescreen and having these issues open is confusing. All issues will block bug 1231115 so we can use that to re-visit any of these if needed.
Blocks: 1231115
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.