1058167 - Split console command button is not active when initially opened

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Brian Grinstead [:bgrins]]

STR:

Open toolbox
Open split console
Close toolbox
Reopen toolbox

Notice that the split console is opened, but the command button is not active

Comment 1

[Brian Grinstead [:bgrins]]

This is because the _buildButtons call happens before the call to openSplitConsole, so the call to isChecked returns false

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: split-cmd-button.patch

https://tbpl.mozilla.org/?tree=Try&rev=ff7bc5e35fcd

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8478710 [details] [diff] [review]
split-cmd-button.patch

Review of attachment 8478710 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/webconsole/console-commands.js
@@ -9,5 @@
>  const { gDevTools } = require("resource:///modules/devtools/gDevTools.jsm");
>  
> -const eventEmitter = new EventEmitter();
> -
> -gDevTools.on("toolbox-ready", (e, toolbox) => {

Waiting for toolbox-ready wasn't working because by then the 'split-console' event had already fired.  That's why it's been moved into the onChange handler (which is fired during buildButtons, before the split-console event fires)

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/8883019fca40

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8883019fca40