1058266 - [Browser2][Home Screen] Browser2 creates bookmarks without proper icons on Home Screen

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Description

[Roland Kunkel [:RolandK]]

Attachment: logcat

Description:
When the user attempts to add a bookmark from the Browser2 app to the Home Screen, the bookmark shortcut is displayed as a rocketship.
 
Repro Steps:
1) Update a Flame device to BuildID: 20140825040204
2) Connect to WiFi or enable cellular data
3) Open Browser2
4) Navigate to any website, click the '...' icon, Add to Home Screen
5) Add to Home Screen
6) Observe shortcut is created without an icon, it displays the rocketship 
  
Actual:
Shortcut is created with the rockship icon

Expected: 
Shortcut is created with an icon related to the webpage

Environmental Variables:
Device: Flame 2.1 Master
BuildID: 20140825040204
Gaia: e424c85eda87a40c0fa64d6a779c3fa368bf770b
Gecko: daa84204a11a
Version: 34.0a1 (2.1 Master)
Firmware: V123
User Agent: Mozilla/5.0 (Mobile; rv:33.0) Gecko/33.0 Firefox/33.0
  
Notes:
I used www.google.com, www.cnn.com, and www.imgur.com to reproduce this issue

Repro frequency: 100%
See attached: screenshot, logcat

Comment 1

[Roland Kunkel [:RolandK]]

This issue is not a regression, Browser2 is a new feature for 2.1.

Comment 2

[Roland Kunkel [:RolandK]]

Attachment: screenshot

Comment 3

[Roland Kunkel [:RolandK]]

Updating reproduction rate.

Out of 10 attempts 9 bookmarks were created with the rocketship icon. 

Repro frequency: 90%

Comment 4

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Bad user experience for a core feature.

Not a regression as Browser2 is a new feature for 2.1.

Comment 5

[Marcia Knous [:marcia]]

Please check this in today's Flame build - I added 5 bookmarks and I see the icon for all of them. Let's see if this is happening with only certain sites - the 5 I added were:

cbs.com
sony.com
nfl.com
mlb.com
nhl.com

In yesterday's build, almost all of the bookmarks I added were missing icons except nascar.com

Comment 6

[Peter Bylenga [:PBylenga]]

Adding qawanted for Comment 5.

Comment 7

[Cody Roesch [:croesch]]

(In reply to Marcia Knous [:marcia - use needinfo] from comment #5)
> Please check this in today's Flame build - I added 5 bookmarks and I see the
> icon for all of them. Let's see if this is happening with only certain sites
> - the 5 I added were:
> 
> cbs.com
> sony.com
> nfl.com
> mlb.com
> nhl.com
> 
> In yesterday's build, almost all of the bookmarks I added were missing icons
> except nascar.com


Marcia,
    I checked with the 5 websites you listed. When going to the website then adding to Homescreen, the icons showed up fine. However I also tried CNN.com and got the missing Icon. So this is hit and miss depending on the website.

    There is more information on this bug that will be provided by smoke team based on other ways they were seeing this problem occurring.

Comment 8

[Cody Roesch [:croesch]]

Here is the build I tested with.

Nightly build
Environmental Variables:
Device: Flame Master
BuildID: 20140826040204
Gaia: 4d1d0ea5a82cddeeab497774cfa1703639e3c7d9
Gecko: dc352a7bf234
Version: 34.0a1 (Master) 
Firmware Version: v123

Comment 9

[Martin Shuman [:Marty]]

Attachment: Bookmark_Icons.png

Smoke Test hit this issue while running this case:
https://moztrap.mozilla.org/manage/case/5856/

'facebook.com' is a website that has a missing icon when added to the home screen, either by navigating to the site in Browser2, or launching the E.me Facebook app from the Rocketbar.

Note: The user is able to long-press the E.me app in the Rocketbar search results and add the app to the home screen without launching the app itself.  If this is done, the E.Me app on the home screen has the proper icon.

I've attached an image to highlight the specifics of this issue.

Comment 10

[Jason Smith [:jsmith]]

QA Wanted - Did this ever work on a 2.1 build?

Comment 11

[Cody Roesch [:croesch]]

It seems that as far back as the vertical homescreen introduction, this issue has occurred. Website bookmarks are showing up without icons. However it's not always the same websites. For example, Cnn.com will be missing a icon in the latest 8/26 Master build but in a 6/29 Master build Cnn.com will work but MLB.com will be missing the icon.

So the answer seems to be no.

Comment 12

[Jason Smith [:jsmith]]

(In reply to Cody Roesch [:croesch] from comment #11)
> It seems that as far back as the vertical homescreen introduction, this
> issue has occurred. Website bookmarks are showing up without icons. However
> it's not always the same websites. For example, Cnn.com will be missing a
> icon in the latest 8/26 Master build but in a 6/29 Master build Cnn.com will
> work but MLB.com will be missing the icon.
> 
> So the answer seems to be no.

I think you are conflating multiple bugs here - different bugs can be present here when using different apps. Can we isolate down which sites are reproducing this bug today & indicate whether those sites worked or not on past 2.1 builds?

Marcia & I also believe that this is not a smoketest blocker. A smoketest blocker would mean this would be busted across the board, but the testing above is showing that this works with some sites, but not with others.

Comment 13

[Marcia Knous [:marcia]]

The use case I was seeing yesterday was simple:

(1) Open browser2 and load a URL
(2) Select the menu button on the right hand side of the screen to expose the "Add to Home Screen"
(3) Add the bookmark to home screen

Comment 14

[Cody Roesch [:croesch]]

Out of the 6 mentioned websites, MLB.com, NFL.com, NHL.com, CBS.com, SONY.com, CNN.com, the following was found.

Cnn.com is the only website that is missing it's icon in the latest Flame 2.1 build and in the oldest build which includes Browser2. The other sites always have their icons.

Latest build
Environmental Variables:
Device: Flame Master
BuildID: 20140826125726
Gaia: ea93363a8c424d65a9ad91438ce6961377a20f98
Gecko: f9bfe115fee5
Version: 34.0a1 (Master) 
Firmware Version: v123

--------------------------------------------------

Oldest Build with Browser2

Environmental Variables:
Device: Flame Master
BuildID: 20140818173616
Gaia: b33b4d9558e0b9eabbfda7be23435e2b38fd40bf
Gecko: 111a1da2a95d
Version: 34.0a1 (Master) 
Firmware Version: v123

Comment 15

[Jason Smith [:jsmith]]

I think we need to refile the bug here. The problem with this bug is that is written to indicate it's a generic problem with apps missing icons, but that's not true. Can you close this bug & refile this issue with a focus on a specific app that's causing the bug here?

Comment 16

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Jason Smith [:jsmith] from comment #15)
> I think we need to refile the bug here. The problem with this bug is that is
> written to indicate it's a generic problem with apps missing icons, but
> that's not true. Can you close this bug & refile this issue with a focus on
> a specific app that's causing the bug here?

Filed bug 1059470.