1058270 - Hide the browser icon when a user flashes gaia

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

It looks like we remove the browser app on upgrade, but it may still be installed on a direct install. While we can kill the upgrade code and browser app all together in 2.4, we should make it so that the browser app does not appear for normal builds.

To do this we can change the manifest role to be "system".

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8478586 [details] [review]
Github pull request

Hey Guys - I feel like we should land something simple like this to hide the old browser app and get people dogfooding 100%.

What do you think?

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8478586 [details] [review]
Github pull request

Sounds fine to me, but I defer to anyone who has more knowledge of system browser than I do, so benfrancis's r+ is the one that matters :)

Comment 4

[Kevin Grandon :kgrandon]

(In reply to Kyle Machulis [:kmachulis] [:qdot] from comment #3)
> Sounds fine to me, but I defer to anyone who has more knowledge of system
> browser than I do, so benfrancis's r+ is the one that matters :)

Thanks Kyle. We need to move insanely quickly this week, so I'll probably land with your review and Ben can leave any follow-ups. I've also included a small fix to properly position the new Browser icon. I'll wait for try to be green before landing.

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8478586 [details] [review]
Github pull request

Let's go with Kyle's review for now. Ben - let me know if you have any concerns/follow-ups.

Comment 6

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/72150cd7e5effabc4d256d4239b8a504f4f2080d